From: Stephen Warren <swarren@wwwdotorg.org>
To: Mark Zhang <markz@nvidia.com>
Cc: linux@arm.linux.org.uk, linux-tegra@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dt: tegra: ventana: define pinmux for ddc
Date: Fri, 19 Oct 2012 09:48:56 -0600 [thread overview]
Message-ID: <50817668.6020709@wwwdotorg.org> (raw)
In-Reply-To: <1350626311-18131-1-git-send-email-markz@nvidia.com>
On 10/18/2012 11:58 PM, Mark Zhang wrote:
> Define pinmux for DDC. The DDC pinmux in Ventana is 2 pins in I2C2.
> +++ b/arch/arm/boot/dts/tegra20-ventana.dts
> - ddc {
> - nvidia,pins = "ddc", "owc", "spdi", "spdo",
> - "uac";
> - nvidia,function = "rsvd2";
> - };
So that removes the entries for 5 pin groups, yet below, entries are
only added for the ddc and pta pingroups, so the other 4 pin groups
become unconfigured.
> +
> + state_i2cmux_ddc: pinmux_i2cmux_ddc {
> + ddc {
> + nvidia,pins = "ddc";
> + nvidia,function = "i2c2";
> + };
> + pta {
> + nvidia,pins = "pta";
> + nvidia,function = "rsvd4";
> + };
Does this actually work? The pta pingroup is configured by the "hog"
pinctrl state of the pinctrl node itself, so this state should fail to
be applied since it attempts to touch the same pingroup.
> + i2cmux {
...
> + i2c@1 {
> + reg = <1>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + smart-battery@b {
> + compatible = "ti,bq24617", "smart-battery-1.1";
> + reg = <0xb>;
> + ti,i2c-retry-count = <2>;
> + ti,poll-retry-count = <10>;
> + };
That wasn't there before. Does that device actually exist on Ventana?
Adding it should be a separate patch if so, since this one is just about
introducing the I2C mux, not adding an SBS device. Was this all just
cut/paste from Seaboard without validation?
next prev parent reply other threads:[~2012-10-19 15:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-19 5:58 [PATCH] ARM: dt: tegra: ventana: define pinmux for ddc Mark Zhang
2012-10-19 15:48 ` Stephen Warren [this message]
2012-10-22 7:29 ` Mark Zhang
2012-10-22 17:14 ` Stephen Warren
2012-10-25 6:32 ` Mark Zhang
2012-10-25 15:37 ` Stephen Warren
2012-10-26 6:28 ` Mark Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50817668.6020709@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=markz@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).