From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755071Ab2JZEbs (ORCPT ); Fri, 26 Oct 2012 00:31:48 -0400 Received: from mail-ie0-f174.google.com ([209.85.223.174]:44922 "EHLO mail-ie0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753213Ab2JZEbq (ORCPT ); Fri, 26 Oct 2012 00:31:46 -0400 Message-ID: <508A122F.3090304@gmail.com> Date: Thu, 25 Oct 2012 22:31:43 -0600 From: Robert Hancock User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121016 Thunderbird/16.0.1 MIME-Version: 1.0 To: Alan Cox CC: "H. Peter Anvin" , "Rafael J. Wysocki" , Ondrej Zary , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Enable A20 using KBC for some MSI laptops to fix S3 resume References: <201210240847.52417.linux@rainbow-software.org> <450396555.xT2D53NWjT@vostro.rjw.lan> <5e64035c-9ee0-4e76-a348-d4f9f6c7b198@email.android.com> <20121024210941.3c7d2cfb@pyramind.ukuu.org.uk> In-Reply-To: <20121024210941.3c7d2cfb@pyramind.ukuu.org.uk> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/24/2012 02:09 PM, Alan Cox wrote: > On Wed, 24 Oct 2012 12:36:04 -0700 > "H. Peter Anvin" wrote: > >> Minor concern: it should do the wait for ready before sending each command. > > Can we get a command line to do this quirk too - it strikes me that if > the MSIs rely upon it then it may be something Windows always does so > will be useful to try on other problem machines as an experiment. I agree, one has to keep in mind the age-old question "how does Windows work?" since it surely has no such quirk. I'd say we're sometimes too quick to add these DMI quirks when a more general solution would be somehow figure out how the Linux behavior differs from what Windows is doing.