From: Maciej Falkowski <m.falkowski@samsung.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Marek Szyprowski <m.szyprowski@samsung.com>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Mark Brown <broonie@kernel.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH] dt-bindings: sound: Convert Samsung Exynos5433 TM2(E) audio complex with WM5110 codec to dt-schema
Date: Thu, 26 Sep 2019 13:49:09 +0200 [thread overview]
Message-ID: <50932d65-6d8b-aca2-2bec-d4eedaba0bdc@samsung.com> (raw)
In-Reply-To: <20190924152028.GD9218@pi3>
On 9/24/19 5:20 PM, Krzysztof Kozlowski wrote:
> On Tue, Sep 24, 2019 at 05:01:46PM +0200, Marek Szyprowski wrote:
>> From: Maciej Falkowski <m.falkowski@samsung.com>
>>
>> Convert Samsung Exynos5433 TM2(E) audio complex with WM5110 codec to newer dt-schema format.
>>
>> Signed-off-by: Maciej Falkowski <m.falkowski@samsung.com>
>> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
>> ---
>> .../bindings/sound/samsung,tm2-audio.txt | 42 ----------
>> .../bindings/sound/samsung,tm2-audio.yaml | 83 +++++++++++++++++++
>> 2 files changed, 83 insertions(+), 42 deletions(-)
>> delete mode 100644 Documentation/devicetree/bindings/sound/samsung,tm2-audio.txt
>> create mode 100644 Documentation/devicetree/bindings/sound/samsung,tm2-audio.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/sound/samsung,tm2-audio.txt b/Documentation/devicetree/bindings/sound/samsung,tm2-audio.txt
>> deleted file mode 100644
>> index f5ccc12ddc00..000000000000
>> --- a/Documentation/devicetree/bindings/sound/samsung,tm2-audio.txt
>> +++ /dev/null
>> @@ -1,42 +0,0 @@
>> -Samsung Exynos5433 TM2(E) audio complex with WM5110 codec
>> -
>> -Required properties:
>> -
>> - - compatible : "samsung,tm2-audio"
>> - - model : the user-visible name of this sound complex
>> - - audio-codec : the first entry should be phandle of the wm5110 audio
>> - codec node, as described in ../mfd/arizona.txt;
>> - the second entry should be phandle of the HDMI
>> - transmitter node
>> - - i2s-controller : the list of phandle and argument tuples pointing to
>> - I2S controllers, the first entry should be I2S0 and
>> - the second one I2S1
>> - - audio-amplifier : the phandle of the MAX98504 amplifier
>> - - samsung,audio-routing : a list of the connections between audio components;
>> - each entry is a pair of strings, the first being the
>> - connection's sink, the second being the connection's
>> - source; valid names for sources and sinks are the
>> - WM5110's and MAX98504's pins and the jacks on the
>> - board: HP, SPK, Main Mic, Sub Mic, Third Mic,
>> - Headset Mic
>> - - mic-bias-gpios : GPIO pin that enables the Main Mic bias regulator
>> -
>> -
>> -Example:
>> -
>> -sound {
>> - compatible = "samsung,tm2-audio";
>> - audio-codec = <&wm5110>, <&hdmi>;
>> - i2s-controller = <&i2s0 0>, <&i2s1 0>;
>> - audio-amplifier = <&max98504>;
>> - mic-bias-gpios = <&gpr3 2 0>;
>> - model = "wm5110";
>> - samsung,audio-routing =
>> - "HP", "HPOUT1L",
>> - "HP", "HPOUT1R",
>> - "SPK", "SPKOUT",
>> - "SPKOUT", "HPOUT2L",
>> - "SPKOUT", "HPOUT2R",
>> - "Main Mic", "MICBIAS2",
>> - "IN1R", "Main Mic";
>> -};
>> diff --git a/Documentation/devicetree/bindings/sound/samsung,tm2-audio.yaml b/Documentation/devicetree/bindings/sound/samsung,tm2-audio.yaml
>> new file mode 100644
>> index 000000000000..377f8cbe17b8
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/sound/samsung,tm2-audio.yaml
>> @@ -0,0 +1,83 @@
>> +# SPDX-License-Identifier: GPL-2.0
>> +%YAML 1.2
>> +---
>> +$id: https://protect2.fireeye.com/url?k=ccb9abe11b8a2745.ccb820ae-a91cd712f01d248e&u=http://devicetree.org/schemas/sound/samsung,tm2-audio.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Samsung Exynos SoC Exynos5433 TM2(E) audio complex with WM5110 codec
>> +
>> +maintainers:
>> + - Krzysztof Kozlowski <krzk@kernel.org>
>> + - Sylwester Nawrocki <s.nawrocki@samsung.com>
>> +
>> +properties:
>> + compatible:
>> + const: samsung,tm2-audio
>> +
>> + model:
>> + maxItems: 1
> $ref to string, then maxItems are not needed.
> Add description (copy-paste).
Hi Krzysztof,
You're right, model is not a standard property.
>> +
>> + audio-codec:
>> + allOf:
>> + - $ref: /schemas/types.yaml#/definitions/phandle-array
>> + - items:
>> + - description: |
>> + phandle of the wm5110 audio codec node,
>> + as described in ../mfd/arizona.txt;
>> + - description: phandle of the HDMI transmitter node.
>> +
>> + i2s-controller:
>> + allOf:
>> + - $ref: /schemas/types.yaml#/definitions/phandle-array
>> + - items:
>> + - description: phandle of the I2S0.
>> + - description: phandle of the I2S1.
>> +
>> + audio-amplifier:
> Can you order the nodes here and in required section by name (except
> compatible which should be first)?
Current order is already well-established across bindings (even example).
I think that sorted properties are undesired with that.
Best regards,
Maciej Falkowski
>
> Best regards,
> Krzysztof
>
>
>
next prev parent reply other threads:[~2019-09-26 11:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190924150230eucas1p295da8f6aa018aec4acabc068f6e1afa1@eucas1p2.samsung.com>
2019-09-24 15:01 ` [PATCH] dt-bindings: sound: Convert Samsung Exynos5433 TM2(E) audio complex with WM5110 codec to dt-schema Marek Szyprowski
2019-09-24 15:20 ` Krzysztof Kozlowski
2019-09-26 11:49 ` Maciej Falkowski [this message]
2019-09-26 12:43 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50932d65-6d8b-aca2-2bec-d4eedaba0bdc@samsung.com \
--to=m.falkowski@samsung.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).