From: "Christian König" <deathsimple@vodafone.de>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: Thierry Reding <thierry.reding@avionic-design.de>,
linux-tegra@vger.kernel.org, Dave Airlie <airlied@redhat.com>,
devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm: tegra: Add HDMI support
Date: Fri, 09 Nov 2012 17:00:54 +0100 [thread overview]
Message-ID: <509D28B6.3060207@vodafone.de> (raw)
In-Reply-To: <CACna6rycZ=TGHP7KpVa_r0JSpc6c=PB89pijR9E_4A=bQ=74Bw@mail.gmail.com>
On 09.11.2012 16:45, Rafał Miłecki wrote:
> 2012/11/9 Thierry Reding <thierry.reding@avionic-design.de>:
>> +/* all fields little endian */
>> +struct hdmi_audio_infoframe {
>> + /* PB0 */
>> + u8 csum;
>> +
>> + /* PB1 */
>> + unsigned cc:3; /* channel count */
>> + unsigned res1:1;
>> + unsigned ct:4; /* coding type */
>> +
>> + /* PB2 */
>> + unsigned ss:2; /* sample size */
>> + unsigned sf:3; /* sample frequency */
>> + unsigned res2:3;
>> +
>> + /* PB3 */
>> + unsigned cxt:5; /* coding extention type */
>> + unsigned res3:3;
>> +
>> + /* PB4 */
>> + u8 ca; /* channel/speaker allocation */
>> +
>> + /* PB5 */
>> + unsigned res5:3;
>> + unsigned lsv:4; /* level shift value */
>> + unsigned dm_inh:1; /* downmix inhibit */
>> +
>> + /* PB6-10 reserved */
>> + u8 res6;
>> + u8 res7;
>> + u8 res8;
>> + u8 res9;
>> + u8 res10;
>> +} __packed;
> I was told it won't work on different endian devices. See
> [RFC][PATCH] drm/radeon/hdmi: define struct for AVI infoframe
> http://lists.freedesktop.org/archives/dri-devel/2012-May/022544.html
Yeah, that's indeed true. And honestly adding just another
implementation of the HDMI info frames sounds like somebody should
finally sit down and implement it in a common drm_hdmi.c
Regards,
Christian.
next prev parent reply other threads:[~2012-11-09 16:01 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-09 13:59 [PATCH 0/2] NVIDIA Tegra DRM driver Thierry Reding
2012-11-09 13:59 ` [PATCH 1/2] drm: Add NVIDIA Tegra20 support Thierry Reding
2012-11-09 15:18 ` Rob Clark
2012-11-09 16:00 ` Thierry Reding
2012-11-09 16:26 ` Rob Clark
2012-11-09 21:03 ` Thierry Reding
2012-11-10 18:04 ` Terje Bergström
2012-11-09 22:27 ` Stephen Warren
2012-11-10 0:09 ` Stephen Warren
2012-11-10 9:11 ` Thierry Reding
2012-11-13 8:00 ` Terje Bergström
2012-11-13 8:03 ` Thierry Reding
2012-11-13 8:16 ` Terje Bergström
2012-11-09 13:59 ` [PATCH 2/2] drm: tegra: Add HDMI support Thierry Reding
2012-11-09 15:45 ` Rafał Miłecki
2012-11-09 16:00 ` Christian König [this message]
2012-11-09 16:04 ` Rafał Miłecki
2012-11-09 20:20 ` Thierry Reding
2012-11-10 21:01 ` Thierry Reding
2012-11-10 21:11 ` Thierry Reding
2012-11-11 14:46 ` Daniel Vetter
2012-11-12 7:24 ` Thierry Reding
2012-11-12 9:43 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=509D28B6.3060207@vodafone.de \
--to=deathsimple@vodafone.de \
--cc=airlied@redhat.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@avionic-design.de \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).