linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 00/11] staging: rtl8723bs: remove unused variables
@ 2021-04-09 10:01 Fabio Aiuto
  2021-04-09 10:01 ` [PATCH 01/11] staging: rtl8723bs: remove unused variable in core/rtw_cmd.c Fabio Aiuto
                   ` (10 more replies)
  0 siblings, 11 replies; 12+ messages in thread
From: Fabio Aiuto @ 2021-04-09 10:01 UTC (permalink / raw)
  To: gregkh; +Cc: linux-staging, linux-kernel, Fabio Aiuto, kernel test robot

This patchset fixes some issues warned from kernel test robot in reply
to the following patch:

https://lore.kernel.org/linux-staging/56055b20bc064d7ac1e8f14bd1ed42aba6b02c36.1617802415.git.fabioaiuto83@gmail.com/

This is kernel robot output:

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/staging/rtl8723bs/core/rtw_cmd.c: In function 'rtw_cmd_thread':
>> drivers/staging/rtl8723bs/core/rtw_cmd.c:390:16: warning: variable 'cmd_start_time' set but not used [-Wunused-but-set-variable]
     390 |  unsigned long cmd_start_time;
         |                ^~~~~~~~~~~~~~
   In file included from drivers/staging/rtl8723bs/include/drv_types.h:33,
                    from drivers/staging/rtl8723bs/core/rtw_cmd.c:9:
   At top level:
   drivers/staging/rtl8723bs/include/rtw_security.h:336:28: warning: 'K' defined but not used [-Wunused-const-variable=]
     336 | static const unsigned long K[64] = {
         |                            ^
--
   drivers/staging/rtl8723bs/os_dep/ioctl_linux.c: In function 'rtw_wx_set_mlme':
   drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:1136:6: warning: variable 'reason' set but not used [-Wunused-but-set-variable]
    1136 |  u16 reason;
         |      ^~~~~~
   drivers/staging/rtl8723bs/os_dep/ioctl_linux.c: In function 'rtw_dbg_port':
>> drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:2575:33: warning: variable 'preorder_ctrl' set but not used
+[-Wunused-but-set-variable]
    2575 |       struct recv_reorder_ctrl *preorder_ctrl;
         |                                 ^~~~~~~~~~~~~
   drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:2601:33: warning: variable 'preorder_ctrl' set but not used
+[-Wunused-but-set-variable]
    2601 |       struct recv_reorder_ctrl *preorder_ctrl;
         |                                 ^~~~~~~~~~~~~
   At top level:
   drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:36:27: warning: 'iw_operation_mode' defined but not used [-Wunused-const-variable=]
      36 | static const char * const iw_operation_mode[] = {
         |                           ^~~~~~~~~~~~~~~~~
   In file included from drivers/staging/rtl8723bs/include/drv_types.h:33,
                    from drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:10:
   drivers/staging/rtl8723bs/include/rtw_security.h:336:28: warning: 'K' defined but not used [-Wunused-const-variable=]
     336 | static const unsigned long K[64] = {
         |                            ^

First and fourth patch remove these two issues introduced by the patch above.

Other patches fix other local issues described in kernel test robot output
and other local 'make W=1' compiler warnings.

Unnecessary code blocks are removed as well.

Fabio Aiuto (11):
  staging: rtl8723bs: remove unused variable in core/rtw_cmd.c
  staging: rtl8723bs: remove unused variable and empty for cycles left
    unused in os_dep/ioctl_linux.c
  staging: rtl8723bs: remove unused code block in os_dep/ioctl_linux.c
  staging: rtl8723bs: remove unused variables and code block left unused
    in os_dep/ioctl_linux.c
  staging: rtl8723bs: remove set but unused psta variable in
    rtw_dbg_port() in os_dep/ioctl_linux.c
  staging: rtl8723bs: remove unused variable pstapriv in rtw_dbg_port()
    in os_dep/ioctl_linux.c
  staging: rtl8723bs: remove unused cur_network variable in
    rtw_dbg_port() in os_dep/ioctl_linux.c
  staging: rtl8723bs: remove unused pmlmepriv variable in rtw_dbg_port()
    in os_dep/ioctl_linux.c
  staging: rtl8723bs: remove unused variable declaration in
    include/rtw_security.h
  staging: rtl8723bs: remove unused variable in os_dep/ioctl_linux.c
  staging: rtl8723bs: remove decl of unused static const variable in
    os_dep/ioctl_linux.c

 drivers/staging/rtl8723bs/core/rtw_cmd.c      |  3 --
 .../staging/rtl8723bs/include/rtw_security.h  | 18 --------
 .../staging/rtl8723bs/os_dep/ioctl_linux.c    | 46 -------------------
 3 files changed, 67 deletions(-)

-- 
2.20.1


^ permalink raw reply	[flat|nested] 12+ messages in thread

* [PATCH 01/11] staging: rtl8723bs: remove unused variable in core/rtw_cmd.c
  2021-04-09 10:01 [PATCH 00/11] staging: rtl8723bs: remove unused variables Fabio Aiuto
@ 2021-04-09 10:01 ` Fabio Aiuto
  2021-04-09 10:01 ` [PATCH 02/11] staging: rtl8723bs: remove unused variable and empty for cycles left unused in os_dep/ioctl_linux.c Fabio Aiuto
                   ` (9 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: Fabio Aiuto @ 2021-04-09 10:01 UTC (permalink / raw)
  To: gregkh; +Cc: linux-staging, linux-kernel, Fabio Aiuto, kernel test robot

fix following kernel test robot warning:

   drivers/staging/rtl8723bs/core/rtw_cmd.c:
	In function 'rtw_cmd_thread':
>> drivers/staging/rtl8723bs/core/rtw_cmd.c:390:16:
warning: variable 'cmd_start_time' set
	but not used [-Wunused-but-set-variable]
     390 |  unsigned long cmd_start_time;
         |                ^~~~~~~~~~~~~~

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_cmd.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
index baf8b1e0f43c..e94eb1138cf1 100644
--- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
+++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
@@ -387,7 +387,6 @@ int rtw_cmd_thread(void *context)
 	u8 ret;
 	struct cmd_obj *pcmd;
 	u8 *pcmdbuf;
-	unsigned long cmd_start_time;
 	u8 (*cmd_hdl)(struct adapter *padapter, u8 *pbuf);
 	void (*pcmd_callback)(struct adapter *dev, struct cmd_obj *pcmd);
 	struct adapter *padapter = context;
@@ -438,8 +437,6 @@ int rtw_cmd_thread(void *context)
 			continue;
 		}
 
-		cmd_start_time = jiffies;
-
 		if (rtw_cmd_filter(pcmdpriv, pcmd) == _FAIL) {
 			pcmd->res = H2C_DROPPED;
 			goto post_process;
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [PATCH 02/11] staging: rtl8723bs: remove unused variable and empty for cycles left unused in os_dep/ioctl_linux.c
  2021-04-09 10:01 [PATCH 00/11] staging: rtl8723bs: remove unused variables Fabio Aiuto
  2021-04-09 10:01 ` [PATCH 01/11] staging: rtl8723bs: remove unused variable in core/rtw_cmd.c Fabio Aiuto
@ 2021-04-09 10:01 ` Fabio Aiuto
  2021-04-09 10:01 ` [PATCH 03/11] staging: rtl8723bs: remove unused code block " Fabio Aiuto
                   ` (8 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: Fabio Aiuto @ 2021-04-09 10:01 UTC (permalink / raw)
  To: gregkh; +Cc: linux-staging, linux-kernel, Fabio Aiuto

fix following kernel test robot warnings:

drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:2573:33:
warning: variable ‘preorder_ctrl’ set but
	not used [-Wunused-but-set-variable]
       struct recv_reorder_ctrl *preorder_ctrl;
                                 ^~~~~~~~~~~~~
remove also empty for cycle left unused and counter variable.

Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
---
 drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
index a9820d813d8b..303a236fe8e6 100644
--- a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
+++ b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
@@ -2568,9 +2568,8 @@ static int rtw_dbg_port(struct net_device *dev,
 					break;
 				case 0x09:
 					{
-						int i, j;
+						int i;
 						struct list_head	*plist, *phead;
-						struct recv_reorder_ctrl *preorder_ctrl;
 
 						spin_lock_bh(&pstapriv->sta_hash_lock);
 
@@ -2582,10 +2581,6 @@ static int rtw_dbg_port(struct net_device *dev,
 								psta = container_of(plist, struct sta_info, hash_list);
 
 								plist = get_next(plist);
-
-								if (extra_arg == psta->aid)
-									for (j = 0; j < 16; j++)
-										preorder_ctrl = &psta->recvreorder_ctrl[j];
 							}
 						}
 
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [PATCH 03/11] staging: rtl8723bs: remove unused code block in os_dep/ioctl_linux.c
  2021-04-09 10:01 [PATCH 00/11] staging: rtl8723bs: remove unused variables Fabio Aiuto
  2021-04-09 10:01 ` [PATCH 01/11] staging: rtl8723bs: remove unused variable in core/rtw_cmd.c Fabio Aiuto
  2021-04-09 10:01 ` [PATCH 02/11] staging: rtl8723bs: remove unused variable and empty for cycles left unused in os_dep/ioctl_linux.c Fabio Aiuto
@ 2021-04-09 10:01 ` Fabio Aiuto
  2021-04-09 10:01 ` [PATCH 04/11] staging: rtl8723bs: remove unused variables and code block left unused " Fabio Aiuto
                   ` (7 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: Fabio Aiuto @ 2021-04-09 10:01 UTC (permalink / raw)
  To: gregkh; +Cc: linux-staging, linux-kernel, Fabio Aiuto

remove unused code block which does nothing.

A list is parsed but no value is written outside
the scope of the function rtw_dbg_port.

Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
---
 .../staging/rtl8723bs/os_dep/ioctl_linux.c    | 20 -------------------
 1 file changed, 20 deletions(-)

diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
index 303a236fe8e6..9735522f9cc8 100644
--- a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
+++ b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
@@ -2567,26 +2567,6 @@ static int rtw_dbg_port(struct net_device *dev,
 					}
 					break;
 				case 0x09:
-					{
-						int i;
-						struct list_head	*plist, *phead;
-
-						spin_lock_bh(&pstapriv->sta_hash_lock);
-
-						for (i = 0; i < NUM_STA; i++) {
-							phead = &(pstapriv->sta_hash[i]);
-							plist = get_next(phead);
-
-							while (phead != plist) {
-								psta = container_of(plist, struct sta_info, hash_list);
-
-								plist = get_next(plist);
-							}
-						}
-
-						spin_unlock_bh(&pstapriv->sta_hash_lock);
-
-					}
 					break;
 				case 0x0a:
 					{
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [PATCH 04/11] staging: rtl8723bs: remove unused variables and code block left unused in os_dep/ioctl_linux.c
  2021-04-09 10:01 [PATCH 00/11] staging: rtl8723bs: remove unused variables Fabio Aiuto
                   ` (2 preceding siblings ...)
  2021-04-09 10:01 ` [PATCH 03/11] staging: rtl8723bs: remove unused code block " Fabio Aiuto
@ 2021-04-09 10:01 ` Fabio Aiuto
  2021-04-09 10:01 ` [PATCH 05/11] staging: rtl8723bs: remove set but unused psta variable in rtw_dbg_port() " Fabio Aiuto
                   ` (6 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: Fabio Aiuto @ 2021-04-09 10:01 UTC (permalink / raw)
  To: gregkh; +Cc: linux-staging, linux-kernel, Fabio Aiuto, kernel test robot

fix following kernel test robot warnings:

drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:
In function ‘rtw_dbg_port’:
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:2548:33:
warning: variable ‘preorder_ctrl’ set but
	not used [-Wunused-but-set-variable]
       struct recv_reorder_ctrl *preorder_ctrl;
                                 ^~~~~~~~~~~~~

remove also unnecessary conditional code block.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
---
 drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
index 9735522f9cc8..d70e2d5d51e7 100644
--- a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
+++ b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
@@ -2543,14 +2543,6 @@ static int rtw_dbg_port(struct net_device *dev,
 					break;
 				case 0x05:
 					psta = rtw_get_stainfo(pstapriv, cur_network->network.MacAddress);
-					if (psta) {
-						int i;
-						struct recv_reorder_ctrl *preorder_ctrl;
-
-						for (i = 0; i < 16; i++)
-							preorder_ctrl = &psta->recvreorder_ctrl[i];
-
-					}
 					break;
 				case 0x06:
 					{
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [PATCH 05/11] staging: rtl8723bs: remove set but unused psta variable in rtw_dbg_port() in os_dep/ioctl_linux.c
  2021-04-09 10:01 [PATCH 00/11] staging: rtl8723bs: remove unused variables Fabio Aiuto
                   ` (3 preceding siblings ...)
  2021-04-09 10:01 ` [PATCH 04/11] staging: rtl8723bs: remove unused variables and code block left unused " Fabio Aiuto
@ 2021-04-09 10:01 ` Fabio Aiuto
  2021-04-09 10:01 ` [PATCH 06/11] staging: rtl8723bs: remove unused variable pstapriv " Fabio Aiuto
                   ` (5 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: Fabio Aiuto @ 2021-04-09 10:01 UTC (permalink / raw)
  To: gregkh; +Cc: linux-staging, linux-kernel, Fabio Aiuto

remove set but unused variable. Fix W=1 compiler warning:

drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:
In function ‘rtw_dbg_port’:
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:2443:19:
warning: variable ‘psta’ set but not used [-Wunused-but-set-variable]
  struct sta_info *psta;
                   ^~~~

Remove also the function call that sets this variable.

Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
---
 drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
index d70e2d5d51e7..d4392459082d 100644
--- a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
+++ b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
@@ -2440,7 +2440,6 @@ static int rtw_dbg_port(struct net_device *dev,
 	u8 major_cmd, minor_cmd;
 	u16 arg;
 	u32 extra_arg, *pdata, val32;
-	struct sta_info *psta;
 	struct adapter *padapter = rtw_netdev_priv(dev);
 	struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
 	struct mlme_ext_priv *pmlmeext = &padapter->mlmeextpriv;
@@ -2542,7 +2541,6 @@ static int rtw_dbg_port(struct net_device *dev,
 
 					break;
 				case 0x05:
-					psta = rtw_get_stainfo(pstapriv, cur_network->network.MacAddress);
 					break;
 				case 0x06:
 					{
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [PATCH 06/11] staging: rtl8723bs: remove unused variable pstapriv in rtw_dbg_port() in os_dep/ioctl_linux.c
  2021-04-09 10:01 [PATCH 00/11] staging: rtl8723bs: remove unused variables Fabio Aiuto
                   ` (4 preceding siblings ...)
  2021-04-09 10:01 ` [PATCH 05/11] staging: rtl8723bs: remove set but unused psta variable in rtw_dbg_port() " Fabio Aiuto
@ 2021-04-09 10:01 ` Fabio Aiuto
  2021-04-09 10:01 ` [PATCH 07/11] staging: rtl8723bs: remove unused cur_network variable " Fabio Aiuto
                   ` (4 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: Fabio Aiuto @ 2021-04-09 10:01 UTC (permalink / raw)
  To: gregkh; +Cc: linux-staging, linux-kernel, Fabio Aiuto

remove unused variable. W=1 compiler issue:

drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:
In function ‘rtw_dbg_port’:
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:2448:19:
warning: unused variable ‘pstapriv’ [-Wunused-variable]
  struct sta_priv *pstapriv = &padapter->stapriv;

Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
---
 drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
index d4392459082d..ae74623bf1a1 100644
--- a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
+++ b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
@@ -2445,8 +2445,6 @@ static int rtw_dbg_port(struct net_device *dev,
 	struct mlme_ext_priv *pmlmeext = &padapter->mlmeextpriv;
 	struct mlme_ext_info *pmlmeinfo = &(pmlmeext->mlmext_info);
 	struct wlan_network *cur_network = &(pmlmepriv->cur_network);
-	struct sta_priv *pstapriv = &padapter->stapriv;
-
 
 	pdata = (u32 *)&wrqu->data;
 
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [PATCH 07/11] staging: rtl8723bs: remove unused cur_network variable in rtw_dbg_port() in os_dep/ioctl_linux.c
  2021-04-09 10:01 [PATCH 00/11] staging: rtl8723bs: remove unused variables Fabio Aiuto
                   ` (5 preceding siblings ...)
  2021-04-09 10:01 ` [PATCH 06/11] staging: rtl8723bs: remove unused variable pstapriv " Fabio Aiuto
@ 2021-04-09 10:01 ` Fabio Aiuto
  2021-04-09 10:01 ` [PATCH 08/11] staging: rtl8723bs: remove unused pmlmepriv " Fabio Aiuto
                   ` (3 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: Fabio Aiuto @ 2021-04-09 10:01 UTC (permalink / raw)
  To: gregkh; +Cc: linux-staging, linux-kernel, Fabio Aiuto

remove unused variable. Fix W=1 compiler warning:

drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:
In function ‘rtw_dbg_port’:
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:2447:23:
warning: unused variable ‘cur_network’ [-Wunused-variable]
  struct wlan_network *cur_network = &(pmlmepriv->cur_network);

Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
---
 drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
index ae74623bf1a1..2f215e5e28b0 100644
--- a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
+++ b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
@@ -2444,7 +2444,6 @@ static int rtw_dbg_port(struct net_device *dev,
 	struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
 	struct mlme_ext_priv *pmlmeext = &padapter->mlmeextpriv;
 	struct mlme_ext_info *pmlmeinfo = &(pmlmeext->mlmext_info);
-	struct wlan_network *cur_network = &(pmlmepriv->cur_network);
 
 	pdata = (u32 *)&wrqu->data;
 
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [PATCH 08/11] staging: rtl8723bs: remove unused pmlmepriv variable in rtw_dbg_port() in os_dep/ioctl_linux.c
  2021-04-09 10:01 [PATCH 00/11] staging: rtl8723bs: remove unused variables Fabio Aiuto
                   ` (6 preceding siblings ...)
  2021-04-09 10:01 ` [PATCH 07/11] staging: rtl8723bs: remove unused cur_network variable " Fabio Aiuto
@ 2021-04-09 10:01 ` Fabio Aiuto
  2021-04-09 10:01 ` [PATCH 09/11] staging: rtl8723bs: remove unused variable declaration in include/rtw_security.h Fabio Aiuto
                   ` (2 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: Fabio Aiuto @ 2021-04-09 10:01 UTC (permalink / raw)
  To: gregkh; +Cc: linux-staging, linux-kernel, Fabio Aiuto

remove unused variable. Fix W=1 compiler warning:

drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:
In function ‘rtw_dbg_port’:
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:2444:20:
warning: unused variable ‘pmlmepriv’ [-Wunused-variable]
  struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);

Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
---
 drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
index 2f215e5e28b0..0ff6fbbb4e4f 100644
--- a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
+++ b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
@@ -2441,7 +2441,6 @@ static int rtw_dbg_port(struct net_device *dev,
 	u16 arg;
 	u32 extra_arg, *pdata, val32;
 	struct adapter *padapter = rtw_netdev_priv(dev);
-	struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
 	struct mlme_ext_priv *pmlmeext = &padapter->mlmeextpriv;
 	struct mlme_ext_info *pmlmeinfo = &(pmlmeext->mlmext_info);
 
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [PATCH 09/11] staging: rtl8723bs: remove unused variable declaration in include/rtw_security.h
  2021-04-09 10:01 [PATCH 00/11] staging: rtl8723bs: remove unused variables Fabio Aiuto
                   ` (7 preceding siblings ...)
  2021-04-09 10:01 ` [PATCH 08/11] staging: rtl8723bs: remove unused pmlmepriv " Fabio Aiuto
@ 2021-04-09 10:01 ` Fabio Aiuto
  2021-04-09 10:01 ` [PATCH 10/11] staging: rtl8723bs: remove unused variable in os_dep/ioctl_linux.c Fabio Aiuto
  2021-04-09 10:01 ` [PATCH 11/11] staging: rtl8723bs: remove decl of unused static const " Fabio Aiuto
  10 siblings, 0 replies; 12+ messages in thread
From: Fabio Aiuto @ 2021-04-09 10:01 UTC (permalink / raw)
  To: gregkh; +Cc: linux-staging, linux-kernel, Fabio Aiuto

fix following kernel test robot warning:

   At top level:
   drivers/staging/rtl8723bs/include/rtw_security.h:336:28:
warning: 'K' defined but not used [-Wunused-const-variable=]
     336 | static const unsigned long K[64] = {
         |                            ^

Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
---
 .../staging/rtl8723bs/include/rtw_security.h   | 18 ------------------
 1 file changed, 18 deletions(-)

diff --git a/drivers/staging/rtl8723bs/include/rtw_security.h b/drivers/staging/rtl8723bs/include/rtw_security.h
index b71f0959108b..5c787e999aab 100644
--- a/drivers/staging/rtl8723bs/include/rtw_security.h
+++ b/drivers/staging/rtl8723bs/include/rtw_security.h
@@ -332,24 +332,6 @@ static inline u32 rotr(u32 val, int bits)
 /* This is based on SHA256 implementation in LibTomCrypt that was released into
  * public domain by Tom St Denis. */
 
-/* the K array */
-static const unsigned long K[64] = {
-	0x428a2f98UL, 0x71374491UL, 0xb5c0fbcfUL, 0xe9b5dba5UL, 0x3956c25bUL,
-	0x59f111f1UL, 0x923f82a4UL, 0xab1c5ed5UL, 0xd807aa98UL, 0x12835b01UL,
-	0x243185beUL, 0x550c7dc3UL, 0x72be5d74UL, 0x80deb1feUL, 0x9bdc06a7UL,
-	0xc19bf174UL, 0xe49b69c1UL, 0xefbe4786UL, 0x0fc19dc6UL, 0x240ca1ccUL,
-	0x2de92c6fUL, 0x4a7484aaUL, 0x5cb0a9dcUL, 0x76f988daUL, 0x983e5152UL,
-	0xa831c66dUL, 0xb00327c8UL, 0xbf597fc7UL, 0xc6e00bf3UL, 0xd5a79147UL,
-	0x06ca6351UL, 0x14292967UL, 0x27b70a85UL, 0x2e1b2138UL, 0x4d2c6dfcUL,
-	0x53380d13UL, 0x650a7354UL, 0x766a0abbUL, 0x81c2c92eUL, 0x92722c85UL,
-	0xa2bfe8a1UL, 0xa81a664bUL, 0xc24b8b70UL, 0xc76c51a3UL, 0xd192e819UL,
-	0xd6990624UL, 0xf40e3585UL, 0x106aa070UL, 0x19a4c116UL, 0x1e376c08UL,
-	0x2748774cUL, 0x34b0bcb5UL, 0x391c0cb3UL, 0x4ed8aa4aUL, 0x5b9cca4fUL,
-	0x682e6ff3UL, 0x748f82eeUL, 0x78a5636fUL, 0x84c87814UL, 0x8cc70208UL,
-	0x90befffaUL, 0xa4506cebUL, 0xbef9a3f7UL, 0xc67178f2UL
-};
-
-
 /* Various logical functions */
 #define RORc(x, y) \
 (((((unsigned long) (x) & 0xFFFFFFFFUL) >> (unsigned long) ((y) & 31)) | \
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [PATCH 10/11] staging: rtl8723bs: remove unused variable in os_dep/ioctl_linux.c
  2021-04-09 10:01 [PATCH 00/11] staging: rtl8723bs: remove unused variables Fabio Aiuto
                   ` (8 preceding siblings ...)
  2021-04-09 10:01 ` [PATCH 09/11] staging: rtl8723bs: remove unused variable declaration in include/rtw_security.h Fabio Aiuto
@ 2021-04-09 10:01 ` Fabio Aiuto
  2021-04-09 10:01 ` [PATCH 11/11] staging: rtl8723bs: remove decl of unused static const " Fabio Aiuto
  10 siblings, 0 replies; 12+ messages in thread
From: Fabio Aiuto @ 2021-04-09 10:01 UTC (permalink / raw)
  To: gregkh; +Cc: linux-staging, linux-kernel, Fabio Aiuto

fix following kernel test robot warning:

drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:
In function ‘rtw_wx_set_mlme’:
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:1128:6:
warning: variable ‘reason’ set but
	not used [-Wunused-but-set-variable]
  u16 reason;
      ^~~~~~

Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
---
 drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
index 0ff6fbbb4e4f..6f52b8fb0d6e 100644
--- a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
+++ b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
@@ -1125,7 +1125,6 @@ static int rtw_wx_set_mlme(struct net_device *dev,
 			     union iwreq_data *wrqu, char *extra)
 {
 	int ret = 0;
-	u16 reason;
 	struct adapter *padapter = rtw_netdev_priv(dev);
 	struct iw_mlme *mlme = (struct iw_mlme *)extra;
 
@@ -1133,8 +1132,6 @@ static int rtw_wx_set_mlme(struct net_device *dev,
 	if (mlme == NULL)
 		return -1;
 
-	reason = mlme->reason_code;
-
 	switch (mlme->cmd) {
 	case IW_MLME_DEAUTH:
 		if (!rtw_set_802_11_disassociate(padapter))
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [PATCH 11/11] staging: rtl8723bs: remove decl of unused static const variable in os_dep/ioctl_linux.c
  2021-04-09 10:01 [PATCH 00/11] staging: rtl8723bs: remove unused variables Fabio Aiuto
                   ` (9 preceding siblings ...)
  2021-04-09 10:01 ` [PATCH 10/11] staging: rtl8723bs: remove unused variable in os_dep/ioctl_linux.c Fabio Aiuto
@ 2021-04-09 10:01 ` Fabio Aiuto
  10 siblings, 0 replies; 12+ messages in thread
From: Fabio Aiuto @ 2021-04-09 10:01 UTC (permalink / raw)
  To: gregkh; +Cc: linux-staging, linux-kernel, Fabio Aiuto

fix following kernel test robot warning:

   At top level:
   drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:36:27:
warning: 'iw_operation_mode' defined but not used
		[-Wunused-const-variable=]
      36 | static const char * const iw_operation_mode[] = {
         |                           ^~~~~~~~~~~~~~~~~

Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
---
 drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
index 6f52b8fb0d6e..e5f0cdc9711e 100644
--- a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
+++ b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
@@ -33,10 +33,6 @@
 static u32 rtw_rates[] = {1000000, 2000000, 5500000, 11000000,
 	6000000, 9000000, 12000000, 18000000, 24000000, 36000000, 48000000, 54000000};
 
-static const char * const iw_operation_mode[] = {
-	"Auto", "Ad-Hoc", "Managed",  "Master", "Repeater", "Secondary", "Monitor"
-};
-
 void indicate_wx_scan_complete_event(struct adapter *padapter)
 {
 	union iwreq_data wrqu;
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2021-04-09 10:15 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-09 10:01 [PATCH 00/11] staging: rtl8723bs: remove unused variables Fabio Aiuto
2021-04-09 10:01 ` [PATCH 01/11] staging: rtl8723bs: remove unused variable in core/rtw_cmd.c Fabio Aiuto
2021-04-09 10:01 ` [PATCH 02/11] staging: rtl8723bs: remove unused variable and empty for cycles left unused in os_dep/ioctl_linux.c Fabio Aiuto
2021-04-09 10:01 ` [PATCH 03/11] staging: rtl8723bs: remove unused code block " Fabio Aiuto
2021-04-09 10:01 ` [PATCH 04/11] staging: rtl8723bs: remove unused variables and code block left unused " Fabio Aiuto
2021-04-09 10:01 ` [PATCH 05/11] staging: rtl8723bs: remove set but unused psta variable in rtw_dbg_port() " Fabio Aiuto
2021-04-09 10:01 ` [PATCH 06/11] staging: rtl8723bs: remove unused variable pstapriv " Fabio Aiuto
2021-04-09 10:01 ` [PATCH 07/11] staging: rtl8723bs: remove unused cur_network variable " Fabio Aiuto
2021-04-09 10:01 ` [PATCH 08/11] staging: rtl8723bs: remove unused pmlmepriv " Fabio Aiuto
2021-04-09 10:01 ` [PATCH 09/11] staging: rtl8723bs: remove unused variable declaration in include/rtw_security.h Fabio Aiuto
2021-04-09 10:01 ` [PATCH 10/11] staging: rtl8723bs: remove unused variable in os_dep/ioctl_linux.c Fabio Aiuto
2021-04-09 10:01 ` [PATCH 11/11] staging: rtl8723bs: remove decl of unused static const " Fabio Aiuto

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).