From: Shan Wei <shanwei88@gmail.com>
To: Steffen Klassert <steffen.klassert@secunet.com>,
Christoph Lameter <cl@linux.com>
Cc: David Miller <davem@davemloft.net>,
NetDev <netdev@vger.kernel.org>,
Herbert Xu <herbert@gondor.hengli.com.au>,
Kernel-Maillist <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 3/9] net: xfrm: use __this_cpu_read per-cpu helper
Date: Tue, 13 Nov 2012 17:33:19 +0800 [thread overview]
Message-ID: <50A213DF.1040103@gmail.com> (raw)
In-Reply-To: <20121113072101.GG22290@secunet.com>
Steffen Klassert said, at 2012/11/13 15:21:
>
> This should just fetch the tfm pointer, so why exactly __this_cpu_read
> is better than __this_cpu_ptr? Please keep in mind that performance is
> not the most important thing here. It's much more important that it
> works in any case.
[0/9] describes why we should submit this series patches.
you are not included in original mail.
this_cpu_ptr relocates and address. this_cpu_read() relocates the address
and performs the fetch. If you want to operate on rda(defined as per_cpu)
then you can only use this_cpu_ptr. this_cpu_read() saves you more instructions
since it can do the relocation and the fetch in one instruction.
More info, please refer to http://www.spinics.net/lists/kernel/msg1435153.html
next prev parent reply other threads:[~2012-11-13 9:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-13 1:52 [PATCH v4 3/9] net: xfrm: use __this_cpu_read per-cpu helper Shan Wei
2012-11-13 7:21 ` Steffen Klassert
2012-11-13 9:33 ` Shan Wei [this message]
2012-11-13 10:48 ` Steffen Klassert
2012-11-13 12:36 ` [PATCH v5 " Shan Wei
2012-11-14 8:43 ` Steffen Klassert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A213DF.1040103@gmail.com \
--to=shanwei88@gmail.com \
--cc=cl@linux.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.hengli.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).