From: Laxman Dewangan <ldewangan@nvidia.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: "sameo@linux.intel.com" <sameo@linux.intel.com>,
"lrg@ti.com" <lrg@ti.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V3 1/2] mfd: add TI TPS80031 mfd core driver
Date: Tue, 13 Nov 2012 22:51:51 -0500 [thread overview]
Message-ID: <50A31557.30704@nvidia.com> (raw)
In-Reply-To: <20121114030412.GO4415@opensource.wolfsonmicro.com>
On 11/13/2012 10:04 PM, Mark Brown wrote:
> * PGP Signed by an unknown key
>
> On Tue, Nov 13, 2012 at 10:01:26PM -0500, Laxman Dewangan wrote:
>
>>> This does not seem sensible. Why would this be optional if it is
>>> useful? In any case, what you're doing in the driver here is clearly
>>> not the way forward.
>> I was thinking of adding wake_enable in struct regmap_irq_chip and
>> decide the wake support based on the value if wake_enable true or
>> wake_base is non-zero. then wake support should be enable.
>> The wake register write will happen only when wake_base is non-zero.
> But to repeat my question why would this be optional?
>
OK, I wanted to make this configurable to preserve the current
functional behavior although I always want to be wakeup from PMIC
devices i.e. gpio or rtc or onkey etc.
If I understand your statement then the wake support should be there and
should enable the wake even if there is no wake_base. The irq_set_wake()
should be called for parent irq if client have called the irq_set_wake()
with interrupts supported by this regmap-irq.
next prev parent reply other threads:[~2012-11-14 3:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-11 15:11 [PATCH V3 0/2] tps80031: Add mfd and regulator driver Laxman Dewangan
2012-11-11 15:12 ` [PATCH V3 1/2] mfd: add TI TPS80031 mfd core driver Laxman Dewangan
2012-11-12 11:30 ` Guennadi Liakhovetski
2012-11-13 7:46 ` Mark Brown
2012-11-13 17:48 ` Laxman Dewangan
2012-11-14 1:22 ` Mark Brown
2012-11-14 2:35 ` Laxman Dewangan
2012-11-14 2:45 ` Mark Brown
2012-11-14 3:01 ` Laxman Dewangan
2012-11-14 3:04 ` Mark Brown
2012-11-14 3:51 ` Laxman Dewangan [this message]
2012-11-11 15:12 ` [PATCH V3 2/2] regulator: tps80031: add regulator driver for tps80031 Laxman Dewangan
2012-11-12 12:28 ` Guennadi Liakhovetski
2012-11-13 6:54 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A31557.30704@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).