linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Terje Bergström" <tbergstrom@nvidia.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Thierry Reding <thierry.reding@avionic-design.de>,
	"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] ARM: tegra: Add Tegra20 host1x support
Date: Wed, 14 Nov 2012 18:45:23 +0200	[thread overview]
Message-ID: <50A3CAA3.2060908@nvidia.com> (raw)
In-Reply-To: <50A3C485.7080704@wwwdotorg.org>

On 14.11.2012 18:19, Stephen Warren wrote:
> I'd rather initialize it explicitly. If setting it to 216MHz works
> fine as Terje indicated, we may as well just do that.

I'd prefer explicit setting, too.

> I suspect the issue with the original code:
> 
>> { "host1x",     "pll_c",        144000000,      false },
> 
> ... is that perhaps the requested 144MHz can't be generated from
> pll_c's 600MHz rate, since there's a simple U7.1 divider there (you
> could get 120, 133.333, 150), so the clock ends up being programmed to
> some incorrect value. In the pll_p/216MHz case, pll_p is programmed to
> generate 216MHz anyway, so requesting the same rate for host1x yields
> a divider of 1 exactly which works fine.

I could try the values you proposed tomorrow when I get back to office.
I believe we've always kept host1x under non-fractional dividers, so I'd
like to try 150MHz on Ventana and 150MHz and 300MHz on Cardhu.

600MHz sounds pretty high for PLLC on Tegra20. For Tegra30 it would be
understandable. In internal kernel I believe we have lower rate for
Tegra20 PLLC. Do we have anything running from PLLC in Tegra20 upstream
kernel?

Terje

  reply	other threads:[~2012-11-14 16:45 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-09 13:20 [PATCH 0/2] Device tree updates for host1x support Thierry Reding
2012-11-09 13:20 ` [PATCH 1/2] ARM: tegra: Add Tegra20 " Thierry Reding
2012-11-12  9:39   ` Mark Zhang
2012-11-13  4:38     ` Mark Zhang
2012-11-13  6:41       ` Thierry Reding
2012-11-13  7:37         ` Mark Zhang
2012-11-13  7:45   ` Mark Zhang
2012-11-13  7:52     ` Thierry Reding
2012-11-13  8:00       ` Mark Zhang
2012-11-13  8:04         ` Thierry Reding
2012-11-13  8:29           ` Mark Zhang
2012-11-14  8:35   ` Terje Bergström
2012-11-14  8:49     ` Thierry Reding
2012-11-14 10:23       ` Terje Bergström
2012-11-14 10:54         ` Thierry Reding
2012-11-14 16:19           ` Stephen Warren
2012-11-14 16:45             ` Terje Bergström [this message]
2012-11-14 18:12               ` Stephen Warren
2012-11-14 20:04             ` Thierry Reding
2012-11-14 20:15               ` Stephen Warren
2012-11-14 20:21                 ` Thierry Reding
2012-11-15  6:56               ` Terje Bergström
2012-11-15  7:11                 ` Thierry Reding
2012-11-14 15:01     ` Thierry Reding
2012-11-14 15:29       ` Terje Bergström
2012-11-14 15:33         ` Thierry Reding
2012-11-09 13:20 ` [PATCH 2/2] ARM: tegra: Add Tegra30 " Thierry Reding
2012-11-13  4:37   ` Mark Zhang
2012-11-13  7:45   ` Mark Zhang
2012-11-13  7:53     ` Thierry Reding
2012-11-09 17:34 ` [PATCH 0/2] Device tree updates for " Stephen Warren
2012-11-09 18:44   ` Thierry Reding
2012-11-09 21:10     ` Stephen Warren
2012-11-15  8:21       ` Prashant Gaikwad
2012-11-15  8:50         ` Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50A3CAA3.2060908@nvidia.com \
    --to=tbergstrom@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=swarren@wwwdotorg.org \
    --cc=thierry.reding@avionic-design.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).