From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756124Ab2KVVDj (ORCPT <rfc822;w@1wt.eu>);
	Thu, 22 Nov 2012 16:03:39 -0500
Received: from terminus.zytor.com ([198.137.202.10]:47438 "EHLO mail.zytor.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755969Ab2KVVDh (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 22 Nov 2012 16:03:37 -0500
Message-ID: <50AE92FD.2090103@zytor.com>
Date: Thu, 22 Nov 2012 13:02:53 -0800
From: "H. Peter Anvin" <hpa@zytor.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121029 Thunderbird/16.0.2
MIME-Version: 1.0
To: Yinghai Lu <yinghai@kernel.org>
CC: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
        "Eric W. Biederman" <ebiederm@xmission.com>,
        linux-kernel@vger.kernel.org, Rob Landley <rob@landley.net>,
        Matt Fleming <matt.fleming@intel.com>
Subject: Re: [PATCH v3 11/12] x86, boot: add fields to support load bzImage
 and ramdisk high
References: <1353482170-10160-1-git-send-email-yinghai@kernel.org> <1353482170-10160-12-git-send-email-yinghai@kernel.org> <50AD0CA1.8000904@zytor.com> <CAE9FiQUSjRT-r5ZE3WHVaKkUOhwFWkm9CTCv1Aa63DOsfMQMiQ@mail.gmail.com> <50AD291A.10600@zytor.com> <CAE9FiQVed0tXhbtmc_Gug0gFZ=s=j=N4B5Vr2_ZTmSj6L-65dw@mail.gmail.com> <a1ca794a-09d4-4d36-8c8c-67100cb3696e@email.android.com> <CAE9FiQXJO8uxT9Gzjv9e8XeiLzwBX7fwTFzDVy=oPfboG4L=3Q@mail.gmail.com> <CAE9FiQWeGz2TkLBrBZcoPrNABx51XK3xk58P+Zam_LRGoJdSiw@mail.gmail.com> <a8b15bf0-4e3b-4fde-9190-26890f9abf77@email.android.com> <CAE9FiQUoj9k0Tbqp8LC8Wb21_s_x8naiWX4zkX9pJG-oFnAQ9g@mail.gmail.com> <50AE70E7.6060204@zytor.com> <CAE9FiQXKgnZyFNujKhMn94+0JQ6jtAHOihmtMOmk_gJi-4_aYQ@mail.gmail.com> <50AE7429.6030308@zytor.com> <CAE9FiQVDbR4d3-SgQ0O3hOWqApN241Pxd7fvF7-wwPWbdX75ug@mail.gmail.com> <50AE902D.5090705@zytor.com>
In-Reply-To: <50AE902D.5090705@zytor.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/22/2012 12:50 PM, H. Peter Anvin wrote:
> On 11/22/2012 12:18 PM, Yinghai Lu wrote:
>>>
>>> If we can get the sentinel hack to work that would probably be
>>> useful, but
>>> we need to understand the exact pathology.
>>
>> for kexec bzImage --real-mode-entry, code after setup_header will be
>> executed.
>>
>> so we could clear value before setup_header after copy 16bit section
>> from bzImage...
>>
>> Index: kexec-tools/kexec/arch/i386/kexec-bzImage.c
>> ===================================================================
>> --- kexec-tools.orig/kexec/arch/i386/kexec-bzImage.c
>> +++ kexec-tools/kexec/arch/i386/kexec-bzImage.c
>> @@ -212,6 +212,16 @@ int do_bzImage_load(struct kexec_info *i
>>       setup_size = kern16_size + command_line_len +
>> PURGATORY_CMDLINE_SIZE;
>>       real_mode = xmalloc(setup_size);
>>       memcpy(real_mode, kernel, kern16_size);
>> +    /*
>> +     * clear value before header
>> +     * not not clear value after header, --real-mode-entry
>> +     * need code after header.
>> +     */
>> +    memset(real_mode, 0, 0x1f1);
>> +    if (!real_mode_entry) {
>> +        /* clear value after setup_header  */
>> +        memset((unsigned char *)real_mode + 0x290, 0, kern16_size -
>> 0x290);
>> +    }
>>
>
> You really should move the memset() into the if() clause as well...
> doesn't matter at the moment, but that is the protocol.
>
> The limit is 0x280, not 0x290, or -- better -- you can use the byte at
> 0x201 to get the size.
>

Not doing so would be wrong, in fact.


-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.