linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dave Kleikamp <dave.kleikamp@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	Zach Brown <zab@zabbo.net>,
	"Maxim V. Patlasov" <mpatlasov@parallels.com>
Subject: Re: [PATCH v4 00/31] loop: Issue O_DIRECT aio using bio_vec
Date: Fri, 23 Nov 2012 11:33:39 -0600	[thread overview]
Message-ID: <50AFB373.8020507@oracle.com> (raw)
In-Reply-To: <20121122194731.GA12057@infradead.org>

On 11/22/2012 01:47 PM, Christoph Hellwig wrote:
> On Wed, Nov 21, 2012 at 04:40:40PM -0600, Dave Kleikamp wrote:
>> It introduces new file ops, read_iter() and write_iter(), that replace the
>> aio_read() and aio_write() operations. The iov_iter structure can now contain
>> either a user-space iovec or a kernel-space bio_vec. Since it would be
>> overly complicated to replace every instance of aio_read() and aio_write(),
>> the old operations are not removed, but file systems implementing the new
>> ones need not keep the old ones.
> 
> How many instance of the old ones are left?  I'd really prefer to make
> the full transition very quickly, even if not nessecarily in a single
> patchset.

The only file systems left are ceph, cifs, fuse and ntfs, but there are
the pipe driver and quite a few character devices that implement
aio_read and aio_write. It would be easy enough put a read/write_iter
wrapper around the non-block devices that return an error or even panic
if !iov_iter_has_iovec(iter), but I didn't like the way it looked.

(I think "git grep -e \\\.aio_read -e \\\.aio_write" find them all.)

If the consensus is to go that route, I'd be happy to work on a
follow-up patchset.

Shaggy

      reply	other threads:[~2012-11-23 17:33 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-21 22:40 [PATCH v4 00/31] loop: Issue O_DIRECT aio using bio_vec Dave Kleikamp
2012-11-21 22:40 ` [PATCH v4 01/31] iov_iter: move into its own file Dave Kleikamp
2012-11-23  8:14   ` Christoph Hellwig
2012-11-23 17:34     ` Dave Kleikamp
2012-11-21 22:40 ` [PATCH v4 02/31] iov_iter: iov_iter_copy_from_user() should use non-atomic copy Dave Kleikamp
2012-11-21 22:40 ` [PATCH v4 03/31] iov_iter: add copy_to_user support Dave Kleikamp
2012-11-21 22:40 ` [PATCH v4 04/31] fuse: convert fuse to use iov_iter_copy_[to|from]_user Dave Kleikamp
2012-11-21 22:40 ` [PATCH v4 05/31] iov_iter: hide iovec details behind ops function pointers Dave Kleikamp
2012-11-21 22:40 ` [PATCH v4 06/31] iov_iter: add bvec support Dave Kleikamp
2012-11-21 22:40 ` [PATCH v4 07/31] iov_iter: add a shorten call Dave Kleikamp
2012-11-21 22:40 ` [PATCH v4 08/31] iov_iter: let callers extract iovecs and bio_vecs Dave Kleikamp
2012-11-21 22:40 ` [PATCH v4 09/31] dio: create a dio_aligned() helper function Dave Kleikamp
2012-11-23  8:19   ` Christoph Hellwig
2012-11-23 17:45     ` Dave Kleikamp
2012-12-03 22:06     ` Dave Kleikamp
2012-11-21 22:40 ` [PATCH v4 10/31] dio: Convert direct_IO to use iov_iter Dave Kleikamp
2012-11-21 22:40 ` [PATCH v4 11/31] dio: add bio_vec support to __blockdev_direct_IO() Dave Kleikamp
2012-11-21 22:40 ` [PATCH v4 12/31] fs: pull iov_iter use higher up the stack Dave Kleikamp
2012-11-21 22:40 ` [PATCH v4 13/31] aio: add aio_kernel_() interface Dave Kleikamp
2012-11-21 22:40 ` [PATCH v4 14/31] aio: add aio support for iov_iter arguments Dave Kleikamp
2012-11-21 22:40 ` [PATCH v4 15/31] bio: add bvec_length(), like iov_length() Dave Kleikamp
2012-11-21 22:40 ` [PATCH v4 16/31] loop: use aio to perform io on the underlying file Dave Kleikamp
2012-11-22 23:06   ` Dave Chinner
2012-12-03 16:59     ` Dave Kleikamp
2012-12-04  2:52       ` Dave Chinner
2012-12-04  2:58         ` Dave Kleikamp
2012-11-21 22:40 ` [PATCH v4 17/31] fs: create file_readable() and file_writable() functions Dave Kleikamp
2012-11-21 22:40 ` [PATCH v4 18/31] fs: use read_iter and write_iter rather than aio_read and aio_write Dave Kleikamp
2012-11-21 22:41 ` [PATCH v4 20/31] ocfs2: add support for read_iter, write_iter, and direct_IO_bvec Dave Kleikamp
2012-11-21 22:41 ` [PATCH v4 21/31] ext4: add support for read_iter and write_iter Dave Kleikamp
2012-11-21 22:41 ` [PATCH v4 22/31] nfs: add support for read_iter, write_iter Dave Kleikamp
2012-11-21 22:41 ` [PATCH v4 23/31] nfs: simplify swap Dave Kleikamp
2012-11-23  8:21   ` Christoph Hellwig
2012-11-23 17:50     ` Dave Kleikamp
2012-11-21 22:41 ` [PATCH v4 24/31] btrfs: add support for read_iter and write_iter Dave Kleikamp
2012-11-21 22:41 ` [PATCH v4 25/31] block_dev: add support for read_iter, write_iter Dave Kleikamp
2012-11-21 22:41 ` [PATCH v4 26/31] xfs: add support for read_iter and write_iter Dave Kleikamp
2012-11-21 22:41 ` [PATCH v4 27/31] gfs2: Convert aio_read/write ops to read/write_iter Dave Kleikamp
2012-11-22  9:51   ` Steven Whitehouse
2012-11-22 22:59     ` Dave Chinner
2012-11-23 17:59       ` Dave Kleikamp
2012-12-03 19:14         ` Dave Kleikamp
2012-11-21 22:41 ` [PATCH v4 28/31] udf: convert file ops from aio_read/write " Dave Kleikamp
2012-11-21 22:41 ` [PATCH v4 29/31] afs: add support for read_iter and write_iter Dave Kleikamp
2012-11-21 22:41 ` [PATCH v4 30/31] ecrpytfs: Convert aio_read/write ops to read/write_iter Dave Kleikamp
2012-11-21 22:41 ` [PATCH v4 31/31] ubifs: convert file ops from aio_read/write " Dave Kleikamp
2012-11-22 19:47 ` [PATCH v4 00/31] loop: Issue O_DIRECT aio using bio_vec Christoph Hellwig
2012-11-23 17:33   ` Dave Kleikamp [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50AFB373.8020507@oracle.com \
    --to=dave.kleikamp@oracle.com \
    --cc=hch@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpatlasov@parallels.com \
    --cc=zab@zabbo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).