From: Mike Dunn <mikedunn@newsguy.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: Nathan Williams <nathan@traverse.com.au>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Artem Bityutskiy <dedekind1@gmail.com>
Subject: Re: [PATCH] mtd cs553x_nand: Initialise ecc.strength before nand_scan()
Date: Tue, 27 Nov 2012 10:11:24 -0800 [thread overview]
Message-ID: <50B5024C.3030907@newsguy.com> (raw)
In-Reply-To: <CAN8TOE-10VYTOS8EbPWxs0HyhdeZBzxL_8gmJsMmXPO1ti_6bQ@mail.gmail.com>
On 11/21/2012 08:08 PM, Brian Norris wrote:
> On Wed, Nov 21, 2012 at 3:42 PM, Nathan Williams <nathan@traverse.com.au> wrote:
>> Loading cs553x_nand with Hynix H27U1G8F2BTR NAND flash causes this bug:
>>
>> kernel BUG at drivers/mtd/nand/nand_base.c:3345!
> ...
>> Initialising ecc.strength before the call to nand_scan() fixes this.
>
> Acked-by: Brian Norris <computersforpeace@gmail.com>
Acked-by: Mike Dunn <mikedunn@newsguy.com>
>
> BTW, I made a quick read through of the other NAND drivers to look for
> similar errors. I think this is the only one where the only
> ecc.strenght initialization occurred after the nand_scan() or
> nand_scan_tail() call.
Thanks for that Brian. I thought I did this when another driver had a similiar
problem a while back. Maybe I just intended to :(
Mike
next prev parent reply other threads:[~2012-11-27 18:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-21 23:42 [PATCH] mtd cs553x_nand: Initialise ecc.strength before nand_scan() Nathan Williams
2012-11-22 4:08 ` Brian Norris
2012-11-27 18:11 ` Mike Dunn [this message]
2012-11-22 11:09 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B5024C.3030907@newsguy.com \
--to=mikedunn@newsguy.com \
--cc=computersforpeace@gmail.com \
--cc=dedekind1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=nathan@traverse.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).