linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joseph Salisbury <joseph.salisbury@canonical.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Norbert Warmuth <nwarmuth@t-online.de>, linux-kernel@vger.kernel.org
Subject: Re: [regression] 3.7+ suspend to RAM/offline CPU fails with nmi_watchdog=0 (bisected)
Date: Wed, 28 Nov 2012 11:56:56 -0500	[thread overview]
Message-ID: <50B64258.7020001@canonical.com> (raw)
In-Reply-To: <868v9s4g7m.fsf@belegost.ivcecceob.t-online.de>

On 11/23/2012 08:11 AM, Norbert Warmuth wrote:
> Thomas Gleixner writes:
>> On Wed, 21 Nov 2012, Norbert Warmuth wrote:
>>> 3.7-rc6 booted with nmi_watchdog=0 fails to suspend to RAM or
>>> offline CPUs. It's reproducable with a KVM guest and physical
>>> system.
>> Does the patch below fix it?
> Yes.
>
> - Norbert
>
>> diff --git a/kernel/watchdog.c b/kernel/watchdog.c
>> index 9d4c8d5..e3ef521 100644
>> --- a/kernel/watchdog.c
>> +++ b/kernel/watchdog.c
>> @@ -368,6 +368,9 @@ static void watchdog_disable(unsigned int cpu)
>>   {
>>   	struct hrtimer *hrtimer = &__raw_get_cpu_var(watchdog_hrtimer);
>>   
>> +	if (!watchdog_enabled)
>> +		return;
>> +
>>   	watchdog_set_prio(SCHED_NORMAL, 0);
>>   	hrtimer_cancel(hrtimer);
>>   	/* disable the perf event */
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

Hi Thomas,

Your patch also fixes a bug[0] reported against Ubuntu.  I assume the 
window for v3.7 is closed.  Will you be submitting this patch for 
inclusion in v3.8?

Thanks,

Joe

[0] http://bugs.launchpad.net/bugs/1079534


  reply	other threads:[~2012-11-28 16:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-21  9:01 [regression] 3.7+ suspend to RAM/offline CPU fails with nmi_watchdog=0 (bisected) Norbert Warmuth
2012-11-23  9:33 ` Thomas Gleixner
2012-11-23 13:11   ` Norbert Warmuth
2012-11-28 16:56     ` Joseph Salisbury [this message]
2012-11-28 20:37       ` Thomas Gleixner
2012-12-04 19:10   ` [tip:core/urgent] watchdog: Fix CPU hotplug regression tip-bot for Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50B64258.7020001@canonical.com \
    --to=joseph.salisbury@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nwarmuth@t-online.de \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).