From: Alexey Kardashevskiy <aik@ozlabs.ru>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH] vfio powerpc: enabled on powernv platform
Date: Fri, 30 Nov 2012 17:16:46 +1100 [thread overview]
Message-ID: <50B84F4E.20809@ozlabs.ru> (raw)
In-Reply-To: <1354162826.1809.241.camel@bling.home>
On 29/11/12 15:20, Alex Williamson wrote:
>> + /* Put tces to the table */
>> + for (i = 0; (i < pages) && !ret; ++i, tce += IOMMU_PAGE_SIZE) {
>> + ret = put_tce(tbl, entry + i, tce, direction);
>> + /*
>> + * As IOMMU page size is always 4K, the system page size
>> + * can be 64K and there is no special tracking for IOMMU pages,
>> + * we only do rlimit check/update for the very first
>> + * 4K IOMMUpage within 64K system page.
>> + */
>> + if (!(tce & ~PAGE_MASK))
>> + ++retpages;
>
> Ah, here's the comment I was looking for, though I'm still not sure
> about the read/write bits.
>
> Isn't there an exploit here that a user can lock pages beyond their
> limits if they just skip mapping the first 4k of each page? Thanks,
Heh. True. Posted another patch with 4K pages per system page usage tracking.
--
Alexey
next prev parent reply other threads:[~2012-11-30 6:16 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20121113033832.GW4696@truffula.fritz.box>
2012-11-20 0:48 ` [PATCH] vfio powerpc: enabled and supported on powernv platform Alexey Kardashevskiy
2012-11-20 18:19 ` Alex Williamson
2012-11-22 11:56 ` Sethi Varun-B16395
2012-11-23 2:02 ` Alexey Kardashevskiy
2012-11-26 15:18 ` Alex Williamson
2012-11-26 18:04 ` Alex Williamson
2012-11-27 0:21 ` Benjamin Herrenschmidt
2012-11-27 3:28 ` Alexey Kardashevskiy
2012-11-27 4:23 ` Alex Williamson
2012-11-26 15:08 ` Alex Williamson
2012-11-23 9:03 ` [PATCH 0/2] vfio powerpc: implemented and enabled Alexey Kardashevskiy
2012-11-23 9:03 ` [PATCH 1/2] vfio powerpc: implemented IOMMU driver for VFIO Alexey Kardashevskiy
2012-11-26 18:20 ` Alex Williamson
2012-11-27 4:06 ` Alexey Kardashevskiy
2012-11-27 4:29 ` Alex Williamson
2012-11-27 4:58 ` Alexey Kardashevskiy
2012-11-27 5:06 ` David Gibson
2012-11-27 5:07 ` Alex Williamson
2012-11-28 7:21 ` [PATCH] " Alexey Kardashevskiy
2012-11-28 21:01 ` Alex Williamson
2012-11-29 3:51 ` Alexey Kardashevskiy
2012-11-23 9:03 ` [PATCH 2/2] vfio powerpc: enabled on powernv platform Alexey Kardashevskiy
2012-11-27 4:41 ` Alex Williamson
2012-11-28 7:18 ` [PATCH] " Alexey Kardashevskiy
2012-11-28 21:30 ` Alex Williamson
2012-11-29 3:53 ` Alexey Kardashevskiy
2012-11-29 4:20 ` Alex Williamson
2012-11-30 6:14 ` Alexey Kardashevskiy
2012-11-30 16:48 ` Alex Williamson
2012-12-01 0:14 ` Alexey Kardashevskiy
2012-11-30 6:16 ` Alexey Kardashevskiy [this message]
2012-12-03 2:52 ` [PATCH 0/2] vfio on power: yet another try Alexey Kardashevskiy
2012-12-03 2:52 ` [PATCH 1/2] vfio powerpc: enabled on powernv platform Alexey Kardashevskiy
2012-12-03 17:35 ` Alex Williamson
2012-12-04 8:12 ` Alexey Kardashevskiy
2012-12-04 15:51 ` Alex Williamson
2012-12-07 7:35 ` [PATCH] " Alexey Kardashevskiy
2012-12-07 17:38 ` Alex Williamson
2012-12-12 6:14 ` Alexey Kardashevskiy
2012-12-12 14:34 ` Alex Williamson
2012-12-13 2:29 ` Benjamin Herrenschmidt
2012-12-13 6:27 ` Alexey Kardashevskiy
2012-12-13 6:28 ` [PATCH] iommu: moving initialization earlier Alexey Kardashevskiy
2012-12-13 15:48 ` Alex Williamson
2012-12-16 11:20 ` Joerg Roedel
2013-01-04 8:21 ` Alexey Kardashevskiy
2013-01-06 9:49 ` Joerg Roedel
2012-12-12 12:34 ` [PATCH] vfio powerpc: enabled on powernv platform Alexey Kardashevskiy
2012-12-12 12:38 ` Alexey Kardashevskiy
2012-12-12 23:30 ` Alex Williamson
2012-12-13 2:24 ` Alexey Kardashevskiy
2012-12-13 2:39 ` Benjamin Herrenschmidt
2012-12-13 2:57 ` Benjamin Herrenschmidt
2012-12-13 3:22 ` Alex Williamson
2012-12-03 2:52 ` [PATCH 2/2] vfio powerpc: implemented IOMMU driver for VFIO Alexey Kardashevskiy
2012-12-03 17:53 ` Alex Williamson
2012-12-07 7:34 ` [PATCH] " Alexey Kardashevskiy
2012-12-07 17:01 ` Alex Williamson
2012-12-12 6:59 ` Alexey Kardashevskiy
2012-12-12 14:36 ` Alex Williamson
2012-12-12 12:35 ` Alexey Kardashevskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B84F4E.20809@ozlabs.ru \
--to=aik@ozlabs.ru \
--cc=alex.williamson@redhat.com \
--cc=benh@kernel.crashing.org \
--cc=david@gibson.dropbear.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).