From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753592Ab2LELGG (ORCPT ); Wed, 5 Dec 2012 06:06:06 -0500 Received: from cantor2.suse.de ([195.135.220.15]:34463 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751676Ab2LELGC (ORCPT ); Wed, 5 Dec 2012 06:06:02 -0500 Message-ID: <50BF2A95.9070704@suse.cz> Date: Wed, 05 Dec 2012 12:05:57 +0100 From: Michal Marek User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120825 Thunderbird/15.0 MIME-Version: 1.0 To: James Hogan Cc: Takashi Iwai , Rusty Russell , David Howells , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] MODSIGN: Avoid using .incbin in C source References: <1354616321-13520-2-git-send-email-mmarek@suse.cz> <1354616321-13520-1-git-send-email-mmarek@suse.cz> <22396.1354645048@warthog.procyon.org.uk> <87hao1gyiv.fsf@rustcorp.com.au> <20121205095057.GA26543@sepie.suse.cz> <50BF2262.7080603@imgtec.com> In-Reply-To: <50BF2262.7080603@imgtec.com> X-Enigmail-Version: 1.4.4 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dne 5.12.2012 11:30, James Hogan napsal(a): > However I think it's unfortunate having to stringify from C as it's > pretty much always required to be in string form when used from a C > file, usually in an asm block. Any objection to defining SYMBOL_PREFIX > with the quotes around it for _c_flags only? E.g. see below After Takashi's patch is applied, there will be no user of the SYMBOL_PREFIX in C source. But it would probably be more convenient for potential new users. > +_c_sym_flags = -DSYMBOL_PREFIX=\"$(patsubst "%",%,$(CONFIG_SYMBOL_PREFIX))\" Maybe simply -DDSYMBOL_PREFIX='$(or $(CONFIG_SYMBOL_PREFIX),"")' ? The single quotes are needed either way, to prevent the shell eating the double quotes. Michal