From: Tim Gardner <tim.gardner@canonical.com>
To: Dave Airlie <airlied@gmail.com>
Cc: linux-kernel@vger.kernel.org,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
dri-devel@lists.freedesktop.org,
David Howells <dhowells@redhat.com>,
Dave Airlie <airlied@redhat.com>
Subject: Re: [PATCH 3.7-rc8] ttm: Fix possible _manager memory allocation oops
Date: Thu, 06 Dec 2012 16:05:27 -0700 [thread overview]
Message-ID: <50C124B7.4070502@canonical.com> (raw)
In-Reply-To: <CAPM=9ty_PfiQ9Cd5CRNnQbZ7Ea-69qCUR7JM=BA-n_egDnOE5g@mail.gmail.com>
On 12/06/2012 03:46 PM, Dave Airlie wrote:
>>
>> ttm_page_pool_init_locked(&_manager->wc_pool, GFP_HIGHUSER, "wc");
>>
>> @@ -817,6 +821,7 @@ int ttm_page_alloc_init(struct ttm_mem_global *glob, unsigned max_pages)
>> &glob->kobj, "pool");
>> if (unlikely(ret != 0)) {
>> kobject_put(&_manager->kobj);
>> + kfree(_manager);
>> _manager = NULL;
>
> I don;t think this is, since the kobject_put shuold free it.
>
kobject_put only frees memory referenced by kobj, but not the memory
pointed at by _manager.
rtg
--
Tim Gardner tim.gardner@canonical.com
next prev parent reply other threads:[~2012-12-06 23:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-06 16:20 [PATCH 3.7-rc8] ttm: Fix possible _manager memory allocation oops Tim Gardner
2012-12-06 22:46 ` Dave Airlie
2012-12-06 23:05 ` Tim Gardner [this message]
2012-12-07 5:59 ` Dave Airlie
2012-12-07 14:16 ` [PATCH v2 " Tim Gardner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C124B7.4070502@canonical.com \
--to=tim.gardner@canonical.com \
--cc=airlied@gmail.com \
--cc=airlied@redhat.com \
--cc=dhowells@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).