From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754490Ab2LJLYw (ORCPT ); Mon, 10 Dec 2012 06:24:52 -0500 Received: from comal.ext.ti.com ([198.47.26.152]:51202 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750758Ab2LJLYv (ORCPT ); Mon, 10 Dec 2012 06:24:51 -0500 Message-ID: <50C5C666.9050105@ti.com> Date: Mon, 10 Dec 2012 16:54:22 +0530 From: Rajendra Nayak User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120827 Thunderbird/15.0 MIME-Version: 1.0 To: Roger Quadros CC: , , , , , , , , , , Subject: Re: [PATCH v4 23/23] mfd: omap-usb-host: Don't spam console on clk_set_parent failure References: <1355134833-5199-1-git-send-email-rogerq@ti.com> <1355134833-5199-24-git-send-email-rogerq@ti.com> In-Reply-To: <1355134833-5199-24-git-send-email-rogerq@ti.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 10 December 2012 03:50 PM, Roger Quadros wrote: > clk_set_parent is expected to fail on OMAP3 platforms. We don't > consider that as fatal so don't spam console. And what if it fails on a non-OMAP3 platform? > > Signed-off-by: Roger Quadros > --- > drivers/mfd/omap-usb-host.c | 18 +++++++++--------- > 1 files changed, 9 insertions(+), 9 deletions(-) > > diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c > index 0bb54393..344ce09 100644 > --- a/drivers/mfd/omap-usb-host.c > +++ b/drivers/mfd/omap-usb-host.c > @@ -657,32 +657,32 @@ static int __devinit usbhs_omap_probe(struct platform_device *pdev) > } > > if (is_ehci_phy_mode(pdata->port_mode[0])) { > - /* for OMAP3 , the clk set paretn fails */ > + /* for OMAP3, clk_set_parent fails */ > ret = clk_set_parent(omap->utmi_clk[0], > omap->xclk60mhsp1_ck); > if (ret != 0) > - dev_err(dev, "xclk60mhsp1_ck set parent" > - "failed error:%d\n", ret); > + dev_dbg(dev, "xclk60mhsp1_ck set parent failed: %d\n", > + ret); > } else if (is_ehci_tll_mode(pdata->port_mode[0])) { > ret = clk_set_parent(omap->utmi_clk[0], > omap->init_60m_fclk); > if (ret != 0) > - dev_err(dev, "init_60m_fclk set parent" > - "failed error:%d\n", ret); > + dev_dbg(dev, "P0 init_60m_fclk set parent failed: %d\n", > + ret); > } > > if (is_ehci_phy_mode(pdata->port_mode[1])) { > ret = clk_set_parent(omap->utmi_clk[1], > omap->xclk60mhsp2_ck); > if (ret != 0) > - dev_err(dev, "xclk60mhsp2_ck set parent" > - "failed error:%d\n", ret); > + dev_dbg(dev, "xclk60mhsp2_ck set parent failed: %d\n", > + ret); > } else if (is_ehci_tll_mode(pdata->port_mode[1])) { > ret = clk_set_parent(omap->utmi_clk[1], > omap->init_60m_fclk); > if (ret != 0) > - dev_err(dev, "init_60m_fclk set parent" > - "failed error:%d\n", ret); > + dev_dbg(dev, "P1 init_60m_fclk set parent failed: %d\n", > + ret); > } > > omap_usbhs_init(dev); >