From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752346Ab2LJMPx (ORCPT ); Mon, 10 Dec 2012 07:15:53 -0500 Received: from smtp.eu.citrix.com ([46.33.159.39]:30245 "EHLO SMTP.EU.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750739Ab2LJMPw (ORCPT ); Mon, 10 Dec 2012 07:15:52 -0500 X-IronPort-AV: E=Sophos;i="4.84,250,1355097600"; d="scan'208";a="32008" Message-ID: <50C5D276.6090009@citrix.com> Date: Mon, 10 Dec 2012 13:15:50 +0100 From: =?ISO-8859-1?Q?Roger_Pau_Monn=E9?= User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Konrad Rzeszutek Wilk CC: "akpm@linux-foundation.org" , "sfr@canb.auug.org.au" , "peterz@infradead.org" , "linux-kernel@vger.kernel.org" , Konrad Rzeszutek Wilk , "xen-devel@lists.xen.org" Subject: Re: [Xen-devel] [PATCH 2/2] xen-blkfront: implement safe version of llist_for_each_entry References: <1354630913-17287-1-git-send-email-roger.pau@citrix.com> <1354630913-17287-2-git-send-email-roger.pau@citrix.com> <20121207202003.GA9462@phenom.dumpdata.com> In-Reply-To: <20121207202003.GA9462@phenom.dumpdata.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/12/12 21:20, Konrad Rzeszutek Wilk wrote: > On Tue, Dec 04, 2012 at 03:21:53PM +0100, Roger Pau Monne wrote: >> Implement a safe version of llist_for_each_entry, and use it in >> blkif_free. Previously grants where freed while iterating the list, >> which lead to dereferences when trying to fetch the next item. > > Looks like xen-blkfront is the only user of this llist_for_each_entry. > > Would it be more prudent to put the macro in the llist.h file? I'm not able to find out who is the maintainer of llist, should I just CC it's author?