From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751229Ab2LJSdQ (ORCPT ); Mon, 10 Dec 2012 13:33:16 -0500 Received: from mxout2.iskon.hr ([213.191.128.81]:34431 "EHLO mxout2.iskon.hr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750803Ab2LJSdP (ORCPT ); Mon, 10 Dec 2012 13:33:15 -0500 X-Remote-IP: 213.191.128.133 Date: Mon, 10 Dec 2012 19:33:10 +0100 From: Zlatko Calusic Organization: Iskon Internet d.d. User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Icedove/17.0 MIME-Version: 1.0 To: Mel Gorman CC: Johannes Weiner , Linus Torvalds , Rik van Riel , linux-mm , Linux Kernel Mailing List References: <20121203194208.GZ24381@cmpxchg.org> <20121204214210.GB20253@cmpxchg.org> <20121205030133.GA17438@wolff.to> <20121206173742.GA27297@wolff.to> <50C32D32.6040800@iskon.hr> <50C3AF80.8040700@iskon.hr> <20121210110337.GH1009@suse.de> <20121210163904.GA22101@cmpxchg.org> <20121210180141.GK1009@suse.de> In-Reply-To: <20121210180141.GK1009@suse.de> Message-ID: <50C62AE6.3030000@iskon.hr> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: kswapd craziness in 3.7 X-Anti-Virus: Kaspersky Anti-Virus for Linux Mail Server 5.6.45/RELEASE, bases: 20121210 #8684041, check: 20121210 clean X-SpamTest-Envelope-From: zlatko.calusic@iskon.hr X-SpamTest-Group-ID: 00000000 X-SpamTest-Info: Profiles 40112 [Dec 10 2012] X-SpamTest-Method: none X-SpamTest-Rate: 0 X-SpamTest-SPF: none X-SpamTest-Status: Not detected X-SpamTest-Status-Extended: not_detected X-SpamTest-Version: SMTP-Filter Version 3.0.0 [0284], KAS30/Release Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10.12.2012 19:01, Mel Gorman wrote: > In this last-minute disaster, I'm not thinking properly at all any more. The > shrink slab disabling should have happened before the loop_again but even > then it's wrong because it's just covering over the problem. > > The way order and testorder interact with how balanced is calculated means > that we potentially call shrink_slab() multiple times and that thing is > global in nature and basically uncontrolled. You could argue that we should > only call shrink_slab() if order-0 watermarks are not met but that will > not necessarily prevent kswapd reclaiming too much. It keeps going back > to balance_pgdat needing its list of requirements drawn up and receive > some major surgery and we're not going to do that as a quick hack. > I was about to apply the patch that you sent, and reboot the server, but it seems there's no point because the patch is flawed? Anyway, if and when you have a proper one, I'll be glad to test it for you and report results. -- Zlatko