From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753863Ab2LQVnX (ORCPT ); Mon, 17 Dec 2012 16:43:23 -0500 Received: from avon.wwwdotorg.org ([70.85.31.133]:50879 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752839Ab2LQVnW (ORCPT ); Mon, 17 Dec 2012 16:43:22 -0500 Message-ID: <50CF91F7.5010402@wwwdotorg.org> Date: Mon, 17 Dec 2012 14:43:19 -0700 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Laxman Dewangan , Prashant Gaikwad CC: linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] ARM: tegra30: Add support for Uart clock source divider as 15.1 References: <1355746101-15291-1-git-send-email-ldewangan@nvidia.com> <1355746101-15291-2-git-send-email-ldewangan@nvidia.com> In-Reply-To: <1355746101-15291-2-git-send-email-ldewangan@nvidia.com> X-Enigmail-Version: 1.4.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/17/2012 05:08 AM, Laxman Dewangan wrote: > Tegra20 uart clock source have the 15.1 clock divider in place of That says Tegra20, but ... > 7.1. Add support for 15.1 clock divider and change the uart clock divider > flag to DIV_U151. > arch/arm/mach-tegra/clock.h | 3 +- > arch/arm/mach-tegra/tegra30_clocks.c | 70 ++++++++++++++++++++++------ > arch/arm/mach-tegra/tegra30_clocks_data.c | 10 ++-- ... the patch only modifies Tegra30. Do both Tegra20 and Tegra30 have this feature; should both clock drivers be updated? BTW, Prashant is reworking the Tegra clock support to be modular, rather than having a single monolithic "Tegra clock" type, and also moving the code to drivers/clk. This patch will conflict signifcantly with that. Please work with him to integrate this patch into his rework series, either before or after his changes, and have him include the patch when he posts his series. You'll also need to think about whether/how your and his series depend on each-other. ... but: Is this a pure bug-fix? If so, I guess this patch should be applied before Prashant's patches, and this patch also Cc: stable?