linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sasha Levin <sasha.levin@oracle.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Senna Tschudin <peter.senna@gmail.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] hlist: drop the node parameter from iterators
Date: Wed, 16 Jan 2013 16:58:10 -0500	[thread overview]
Message-ID: <50F72272.8090303@oracle.com> (raw)
In-Reply-To: <CA+55aFxFb21Ss=-0FUgzQOzPe1=mS11o7J-+Laco09XJvOk9Fg@mail.gmail.com>

On 01/16/2013 03:48 PM, Linus Torvalds wrote:
> On Sun, Jan 13, 2013 at 8:31 AM, Sasha Levin <sasha.levin@oracle.com> wrote:
>> I'm not sure why, but the hlist for each entry iterators were conceived
>> differently from the list ones. While the list ones are nice and elegant:
> 
> So this patch is probably the RightThing(tm) to do, but it's really
> big and makes me nervous. And the fact that there was already one
> problem in the first version doesn't make me feel any more
> warm-and-fuzzy about it.
> 
> I understand that this kind of patch is nice to apply after the merge
> window has closed, but at the same time, it's now *too* long after the
> merge window closed, and even if it wasn't, I'd really like to feel
> like this has gotten more testing than it obviously has. Or some other
> guarantee that there isn't some other subtle issue hiding there.
> 
> So I am going through patches in my mbox, but I really don't feel safe
> enough about this one to apply it.

I agree about the testing part, I doubt anyone besides Peter and myself
gave it a go.

I guess that if you agree that it should go in once it had some more
testing, it can go into linux-next and sit there for the next couple
of weeks until the next merge window opens.

What would be the best way to do that though? see if akpm would take
it into his tree?


Thanks,
Sasha


  reply	other threads:[~2013-01-16 21:59 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-13 16:31 [PATCH v2] hlist: drop the node parameter from iterators Sasha Levin
2013-01-15 16:46 ` Paul E. McKenney
2013-01-16 20:48 ` Linus Torvalds
2013-01-16 21:58   ` Sasha Levin [this message]
2013-01-16 22:04     ` Linus Torvalds
2013-01-16 22:17       ` Sasha Levin
2013-01-31  2:00 Sasha Levin
2013-02-07  0:55 ` Andrew Morton
2013-02-07  1:00   ` Tejun Heo
2013-02-07  1:45     ` Li Zefan
2013-02-07  1:01   ` Sasha Levin
2013-02-07 21:34 ` Andrew Morton
2013-03-04 10:41 ` Paul Bolle
2013-03-04 14:20   ` Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50F72272.8090303@oracle.com \
    --to=sasha.levin@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peter.senna@gmail.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).