From: Anshuman Khandual <anshuman.khandual@arm.com>
To: Michal Hocko <mhocko@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Oscar Salvador <OSalvador@suse.com>, Baoquan He <bhe@redhat.com>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>,
Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH 3/5] mm, memory_hotplug: drop pointless block alignment checks from __offline_pages
Date: Fri, 16 Nov 2018 17:26:41 +0530 [thread overview]
Message-ID: <50a2cbeb-9d1b-d629-6390-c0b3d26f2d72@arm.com> (raw)
In-Reply-To: <20181116083020.20260-4-mhocko@kernel.org>
On 11/16/2018 02:00 PM, Michal Hocko wrote:
> From: Michal Hocko <mhocko@suse.com>
>
> This function is never called from a context which would provide
> misaligned pfn range so drop the pointless check.
>
> Signed-off-by: Michal Hocko <mhocko@suse.com>
> ---
> mm/memory_hotplug.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index 2b2b3ccbbfb5..a92b1b8f6218 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -1554,12 +1554,6 @@ static int __ref __offline_pages(unsigned long start_pfn,
> struct zone *zone;
> struct memory_notify arg;
>
> - /* at least, alignment against pageblock is necessary */
> - if (!IS_ALIGNED(start_pfn, pageblock_nr_pages))
> - return -EINVAL;
> - if (!IS_ALIGNED(end_pfn, pageblock_nr_pages))
> - return -EINVAL;
> -
> mem_hotplug_begin();
>
> /* This makes hotplug much easier...and readable.
>
Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
next prev parent reply other threads:[~2018-11-16 11:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-16 8:30 [PATCH 0/5] mm, memory_hotplug: improve memory offlining failures debugging Michal Hocko
2018-11-16 8:30 ` [PATCH 1/5] mm: print more information about mapping in __dump_page Michal Hocko
2018-11-16 11:55 ` Anshuman Khandual
2018-11-16 13:50 ` William Kucharski
2018-11-16 8:30 ` [PATCH 2/5] mm: lower the printk loglevel for __dump_page messages Michal Hocko
2018-11-16 11:57 ` Anshuman Khandual
2018-11-16 8:30 ` [PATCH 3/5] mm, memory_hotplug: drop pointless block alignment checks from __offline_pages Michal Hocko
2018-11-16 10:34 ` osalvador
2018-11-16 11:19 ` Michal Hocko
2018-11-16 11:56 ` Anshuman Khandual [this message]
2018-11-16 8:30 ` [PATCH 4/5] mm, memory_hotplug: print reason for the offlining failure Michal Hocko
2018-11-16 10:38 ` osalvador
2018-11-16 12:04 ` Anshuman Khandual
2018-11-16 8:30 ` [PATCH 5/5] mm, memory_hotplug: be more verbose for memory offline failures Michal Hocko
2018-11-16 10:47 ` osalvador
2018-11-16 11:22 ` Michal Hocko
2018-11-16 12:29 ` osalvador
2018-11-16 12:07 ` Anshuman Khandual
2018-11-16 11:55 ` [PATCH 0/5] mm, memory_hotplug: improve memory offlining failures debugging Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50a2cbeb-9d1b-d629-6390-c0b3d26f2d72@arm.com \
--to=anshuman.khandual@arm.com \
--cc=OSalvador@suse.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mhocko@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).