From: "Christian König" <christian.koenig@amd.com>
To: Paul Menzel <pmenzel@molgen.mpg.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
Alex Deucher <alexander.deucher@amd.com>
Cc: amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] drm/amdgpu: Change type of module param `ppfeaturemask` to hexint
Date: Fri, 3 Jul 2020 17:29:07 +0200 [thread overview]
Message-ID: <50e7239f-9fab-8484-7aec-085acc5ec658@amd.com> (raw)
In-Reply-To: <20200703142939.28663-3-pmenzel@molgen.mpg.de>
Am 03.07.20 um 16:29 schrieb Paul Menzel:
> The newly added hexint helper is more convenient for bitmasks.
>
> Before:
>
> $ more /sys/module/amdgpu/parameters/ppfeaturemask
> 4294950911
>
> After:
>
> $ more /sys/module/amdgpu/parameters/ppfeaturemask
> 0xffffbfff
>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
Reviewed-by: Christian König <christian.koenig@amd.com> for this one.
Feel free to add my Acked-by to the other two, but I'm not familiar
enough with the code to review those.
Regards,
Christian.
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> index 126e74758a34..5c4263335cba 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> @@ -391,12 +391,12 @@ MODULE_PARM_DESC(sched_hw_submission, "the max number of HW submissions (default
> module_param_named(sched_hw_submission, amdgpu_sched_hw_submission, int, 0444);
>
> /**
> - * DOC: ppfeaturemask (uint)
> + * DOC: ppfeaturemask (hexint)
> * Override power features enabled. See enum PP_FEATURE_MASK in drivers/gpu/drm/amd/include/amd_shared.h.
> * The default is the current set of stable power features.
> */
> MODULE_PARM_DESC(ppfeaturemask, "all power features enabled (default))");
> -module_param_named(ppfeaturemask, amdgpu_pp_feature_mask, uint, 0444);
> +module_param_named(ppfeaturemask, amdgpu_pp_feature_mask, hexint, 0444);
>
> /**
> * DOC: forcelongtraining (uint)
next prev parent reply other threads:[~2020-07-03 15:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-03 14:29 [PATCH v3 1/3] kernel/params.c: Align last argument with a tab Paul Menzel
2020-07-03 14:29 ` [PATCH v3 2/3] moduleparams: Add hexint type parameter Paul Menzel
2020-07-03 14:29 ` [PATCH v3 3/3] drm/amdgpu: Change type of module param `ppfeaturemask` to hexint Paul Menzel
2020-07-03 15:29 ` Christian König [this message]
2020-07-23 13:44 ` Paul Menzel
2020-07-24 7:54 ` Christian König
2020-07-24 20:29 ` Linus Torvalds
2020-07-25 8:44 ` Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50e7239f-9fab-8484-7aec-085acc5ec658@amd.com \
--to=christian.koenig@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmenzel@molgen.mpg.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).