From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Markus Mayer <mmayer@broadcom.com>
Cc: Len Brown <lenb@kernel.org>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/7] ACPI / device_sysfs: make use of new strtolower() function
Date: Sat, 09 Jul 2016 01:22:53 +0200 [thread overview]
Message-ID: <5102225.yjc3cGTUHE@vostro.rjw.lan> (raw)
In-Reply-To: <1468017794-4818-4-git-send-email-mmayer@broadcom.com>
On Friday, July 08, 2016 03:43:10 PM Markus Mayer wrote:
> Call strtolower() rather than walking the string explicitly to convert
> it to lowercase.
>
> Signed-off-by: Markus Mayer <mmayer@broadcom.com>
> ---
>
> Rafael, I left off your ACK, since the implementation of my function
> changed somewhat (doesn't check the argument NULL, doesn't return
> anything). Please let me know if you are still okay with this.
I am, as long as it doesn't change the result, which seems to be the case.
> drivers/acpi/device_sysfs.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/acpi/device_sysfs.c b/drivers/acpi/device_sysfs.c
> index 7b2c48f..1db38c7 100644
> --- a/drivers/acpi/device_sysfs.c
> +++ b/drivers/acpi/device_sysfs.c
> @@ -200,12 +200,10 @@ static int create_of_modalias(struct acpi_device *acpi_dev, char *modalias,
> const union acpi_object *of_compatible, *obj;
> int len, count;
> int i, nval;
> - char *c;
>
> acpi_get_name(acpi_dev->handle, ACPI_SINGLE_NAME, &buf);
> /* DT strings are all in lower case */
> - for (c = buf.pointer; *c != '\0'; c++)
> - *c = tolower(*c);
> + strtolower(buf.pointer);
>
> len = snprintf(modalias, size, "of:N%sT", (char *)buf.pointer);
> ACPI_FREE(buf.pointer);
>
Thanks,
Rafael
next prev parent reply other threads:[~2016-07-08 23:18 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-08 22:43 [PATCH v3 0/7] lib: string: add functions to case-convert strings Markus Mayer
2016-07-08 22:43 ` [PATCH v3 1/7] " Markus Mayer
2016-07-09 12:04 ` Luis de Bethencourt
2016-07-09 15:30 ` Markus Mayer
2016-07-11 22:46 ` Markus Mayer
2016-07-13 17:19 ` Luis de Bethencourt
2016-07-13 22:26 ` Markus Mayer
2016-07-13 22:53 ` Luis de Bethencourt
2016-07-13 23:04 ` Markus Mayer
2016-07-08 22:43 ` [PATCH v3 2/7] drm/nouveau/core: make use of new strlcpytolower() function Markus Mayer
2016-07-08 22:43 ` [PATCH v3 3/7] ACPI / device_sysfs: make use of new strtolower() function Markus Mayer
2016-07-08 23:22 ` Rafael J. Wysocki [this message]
2016-07-08 22:43 ` [PATCH v3 4/7] staging: speakup: replace spk_strlwr() with strlcpytolower() Markus Mayer
2016-07-13 20:57 ` Samuel Thibault
2016-07-08 22:43 ` [PATCH v3 5/7] iscsi-target: replace iscsi_initiatorname_tolower() with strtolower() Markus Mayer
2016-07-20 21:16 ` Nicholas A. Bellinger
2016-07-20 21:17 ` Nicholas A. Bellinger
2016-07-20 21:19 ` Markus Mayer
2016-07-08 22:43 ` [PATCH v3 6/7] drm/nouveau/fifo/gk104: make use of new strcpytoupper() function Markus Mayer
2016-07-08 22:43 ` [PATCH v3 7/7] power_supply: " Markus Mayer
2016-07-10 3:13 ` [PATCH v3 0/7] lib: string: add functions to case-convert strings Chris Metcalf
2016-07-10 4:11 ` Markus Mayer
2016-07-13 22:52 ` Markus Mayer
2016-07-20 20:28 ` Markus Mayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5102225.yjc3cGTUHE@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmayer@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).