From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756525AbcGHXSW (ORCPT ); Fri, 8 Jul 2016 19:18:22 -0400 Received: from cloudserver094114.home.net.pl ([79.96.170.134]:45416 "HELO cloudserver094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751658AbcGHXSP (ORCPT ); Fri, 8 Jul 2016 19:18:15 -0400 From: "Rafael J. Wysocki" To: Markus Mayer Cc: Len Brown , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 3/7] ACPI / device_sysfs: make use of new strtolower() function Date: Sat, 09 Jul 2016 01:22:53 +0200 Message-ID: <5102225.yjc3cGTUHE@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/4.5.0-rc1+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1468017794-4818-4-git-send-email-mmayer@broadcom.com> References: <1468017794-4818-1-git-send-email-mmayer@broadcom.com> <1468017794-4818-4-git-send-email-mmayer@broadcom.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday, July 08, 2016 03:43:10 PM Markus Mayer wrote: > Call strtolower() rather than walking the string explicitly to convert > it to lowercase. > > Signed-off-by: Markus Mayer > --- > > Rafael, I left off your ACK, since the implementation of my function > changed somewhat (doesn't check the argument NULL, doesn't return > anything). Please let me know if you are still okay with this. I am, as long as it doesn't change the result, which seems to be the case. > drivers/acpi/device_sysfs.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/acpi/device_sysfs.c b/drivers/acpi/device_sysfs.c > index 7b2c48f..1db38c7 100644 > --- a/drivers/acpi/device_sysfs.c > +++ b/drivers/acpi/device_sysfs.c > @@ -200,12 +200,10 @@ static int create_of_modalias(struct acpi_device *acpi_dev, char *modalias, > const union acpi_object *of_compatible, *obj; > int len, count; > int i, nval; > - char *c; > > acpi_get_name(acpi_dev->handle, ACPI_SINGLE_NAME, &buf); > /* DT strings are all in lower case */ > - for (c = buf.pointer; *c != '\0'; c++) > - *c = tolower(*c); > + strtolower(buf.pointer); > > len = snprintf(modalias, size, "of:N%sT", (char *)buf.pointer); > ACPI_FREE(buf.pointer); > Thanks, Rafael