From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68889C433E2 for ; Wed, 15 Jul 2020 16:49:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 43E2A2065D for ; Wed, 15 Jul 2020 16:49:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=isovalent-com.20150623.gappssmtp.com header.i=@isovalent-com.20150623.gappssmtp.com header.b="XrZxDHa2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726905AbgGOQtJ (ORCPT ); Wed, 15 Jul 2020 12:49:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726568AbgGOQtH (ORCPT ); Wed, 15 Jul 2020 12:49:07 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7CE8DC08C5DD for ; Wed, 15 Jul 2020 09:49:07 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id q5so3423795wru.6 for ; Wed, 15 Jul 2020 09:49:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=isovalent-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=hUz/UVXmFj5gZkksWixwGiXAm29+FzSoDE9Tp4/NL1g=; b=XrZxDHa2amTrRfCa2T5Rp/q84MXJ1I7b+U90J1WhsNps3hWZdjZbsa02bucGaUTHBg mEU3a1Bw6aEH6emRRQ8GFwROQJTPl18NYZKVKG9O2Mw9qhF596sToQvTQ0L2BvkL3uVn Av2PBRokopzC+dq6d/9GEbgbYI+2m6Aj+xV0cLwOciEG9+R9cfDxT+AzOEFO2v+Z16df 9S5Q+yIWynYnu/0krW4BKngKk9I1xFRVrMBT00E2a90hfYYq2f1TahWze3GSwQ1f4FUK iV/w0R6LawIh0SjtOOBoLF+67ZkBN43rOWo7Sxh/hwYqhKrCMNSZqOdtA+OXKSUqryCc fomw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hUz/UVXmFj5gZkksWixwGiXAm29+FzSoDE9Tp4/NL1g=; b=fwcUVaGN+6y3QHa6/GLnhaLQ++Lq8VqCg8TKKMJdRSAsvPDh70dVfc3Rm5TWNtCz3f Ap6L5bZ2d7vWGX/ig+6FUmR9YMAUQ2YOL3z7pdt4fz22XpIHIKvTLpnAhPMu9INps9d6 Fi6TddhCnZ/J1+cgsGL3pvF9sfAqQ1/FdxTD67mXppYgMm07G+6DdenKhmtr2JzuLzgA YdijnBKqofB/VmSIUB/ummddWeLUVLiU15cE8yaUEDwzUj4nb2iovPO/5NpmuXq9CEph CuJkhYj9V645e7bjh7vKtdP3we+c0/FBt4ksYu8OKTcvRjP32XJjY+fVVy248gXHgbR2 UsZA== X-Gm-Message-State: AOAM530sBeuEWvsEDh9VGYAVN3Mp/un5F2I7RIfm2MW9MPIwM0RAL2um mpK/Vpv9oHd14HdCV0owCCDwr/wQO3XEsfuH X-Google-Smtp-Source: ABdhPJz20Mxi0oSIWkoJNQFwJ7mmOvvCgI7hszvgLA57LfanXcsC/k6Sp0CzUZdQool/5nzby8X8DA== X-Received: by 2002:a5d:408c:: with SMTP id o12mr271208wrp.412.1594831745783; Wed, 15 Jul 2020 09:49:05 -0700 (PDT) Received: from [192.168.1.12] ([194.35.117.124]) by smtp.gmail.com with ESMTPSA id f15sm4170272wmj.44.2020.07.15.09.49.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Jul 2020 09:49:05 -0700 (PDT) Subject: Re: [PATCH] tools/bpftool: Fix error return code in do_skeleton() To: YueHaibing , ast@kernel.org, daniel@iogearbox.net, kafai@fb.com, songliubraving@fb.com, yhs@fb.com, andriin@fb.com, john.fastabend@gmail.com, kpsingh@chromium.org Cc: netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200715031353.14692-1-yuehaibing@huawei.com> From: Quentin Monnet Message-ID: <51033bf4-c718-2939-cf18-e5e219e7beb1@isovalent.com> Date: Wed, 15 Jul 2020 17:49:04 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200715031353.14692-1-yuehaibing@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2020-07-15 11:13 UTC+0800 ~ YueHaibing > The error return code should be PTR_ERR(obj) other than > PTR_ERR(NULL). > > Fixes: 5dc7a8b21144 ("bpftool, selftests/bpf: Embed object file inside skeleton") > Signed-off-by: YueHaibing Reviewed-by: Quentin Monnet Thanks!