From: Alexander Holler <holler@ahsoftware.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
Bernie Thompson <bernie@plugable.com>,
Steve Glendinning <steve.glendinning@shawell.net>,
stable@vger.kernel.org
Subject: Re: [PATCH 2/3 v2] fb: udlfb: fix hang at disconnect
Date: Tue, 29 Jan 2013 21:56:47 +0100 [thread overview]
Message-ID: <5108378F.80003@ahsoftware.de> (raw)
In-Reply-To: <5108329E.2050802@ahsoftware.de>
Am 29.01.2013 21:35, schrieb Alexander Holler:
>
> So, if the above down_timeout_killable() is only down_interruptible(),
> as in kernel 3.7.5, the box would not shutdown afterwards, because on
> shutdown no signal would be send to that kernel-thread which called
> dlfb_free_urb_list().
>
> A last note: dlfb_usb_disconnect() (thus dlfb_free_urb_list()) isn't
> called on shutdown if the device would still be connected. So the
> problem only might happen, if the screen will be disconnected before
> shutdown (and an urb gets missed). So the subject of my patch is
> correct. ;)
>
> </monologue>
Hmm, wrong, sorry, I still have something to add: As no signal arrives
at all, v1 of that patch is enough and the implementation of
down_timeout_killable() isn't necessary at all.
If there is a chance that the patch would be Acked-by by someone, I
would made a v3, replacing
+ ret = down_timeout(&dev->urbs.limit_sem, GET_URB_TIMEOUT);
in v1 with
+ ret = down_timeout(&dev->urbs.limit_sem, FREE_URB_TIMEOUT);
as this seems to be what it should be.
Regards,
Alexander
next prev parent reply other threads:[~2013-01-29 20:57 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-12 13:20 [PATCH] fb: udlfb: fix hang at disconnect Alexander Holler
2013-01-12 22:22 ` Bernie Thompson
2013-01-13 12:05 ` Alexander Holler
2013-01-13 12:24 ` Alexander Holler
2013-01-25 18:49 ` [PATCH 1/3] semaphore: introduce down_timeout_killable() Alexander Holler
2013-01-25 18:49 ` [PATCH 2/3 v2] fb: udlfb: fix hang at disconnect Alexander Holler
2013-01-29 0:22 ` Andrew Morton
2013-01-29 0:56 ` Alexander Holler
2013-01-29 10:35 ` Alexander Holler
2013-01-29 11:11 ` Alexander Holler
2013-01-29 15:51 ` Alexander Holler
2013-01-29 20:35 ` Alexander Holler
2013-01-29 20:56 ` Alexander Holler [this message]
2013-02-04 1:14 ` Greg KH
2013-02-04 12:05 ` Alexander Holler
2013-02-04 19:17 ` Alexander Holler
2013-02-04 19:25 ` Greg KH
2013-02-05 7:08 ` Alexander Holler
2013-02-05 17:22 ` Greg KH
2013-02-05 17:36 ` Alexander Holler
2013-02-08 4:07 ` Dave Airlie
2013-02-08 9:53 ` Alexander Holler
2013-01-25 18:49 ` [PATCH 3/3] fb: smscufx: " Alexander Holler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5108378F.80003@ahsoftware.de \
--to=holler@ahsoftware.de \
--cc=FlorianSchandinat@gmx.de \
--cc=akpm@linux-foundation.org \
--cc=bernie@plugable.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=steve.glendinning@shawell.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).