From: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Yinghai Lu <yinghai@kernel.org>, Toshi Kani <toshi.kani@hp.com>
Subject: Re: [PATCH 1/2] ACPI / scan: Fix acpi_bus_get_device() check in acpi_match_device()
Date: Thu, 31 Jan 2013 12:04:39 +0900 [thread overview]
Message-ID: <5109DF47.30305@jp.fujitsu.com> (raw)
In-Reply-To: <6099377.PFvsxPeyib@vostro.rjw.lan>
2013/01/31 7:03, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> Since acpi_bus_get_device() returns int and not acpi_status, change
> acpi_match_device() so that it doesn't apply ACPI_FAILURE() to the
> return value of acpi_bus_get_device().
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
I have no objection.
Acked-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
> drivers/acpi/scan.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: linux-pm/drivers/acpi/scan.c
> ===================================================================
> --- linux-pm.orig/drivers/acpi/scan.c
> +++ linux-pm/drivers/acpi/scan.c
> @@ -491,9 +491,9 @@ const struct acpi_device_id *acpi_match_
> const struct device *dev)
> {
> struct acpi_device *adev;
> + acpi_handle handle = ACPI_HANDLE(dev);
>
> - if (!ids || !ACPI_HANDLE(dev)
> - || ACPI_FAILURE(acpi_bus_get_device(ACPI_HANDLE(dev), &adev)))
> + if (!ids || !handle || acpi_bus_get_device(handle, &adev))
> return NULL;
>
> return __acpi_match_device(adev, ids);
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2013-01-31 3:05 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-30 22:02 [PATCH 0/2] ACPI / scan: Fix and cleanup related to acpi_bus_get_device() Rafael J. Wysocki
2013-01-30 22:03 ` [PATCH 1/2] ACPI / scan: Fix acpi_bus_get_device() check in acpi_match_device() Rafael J. Wysocki
2013-01-31 3:04 ` Yasuaki Ishimatsu [this message]
2013-01-31 3:12 ` [PATCH 0/4] Fix acpi_bus_get_device() check Yasuaki Ishimatsu
2013-01-31 3:14 ` Yasuaki Ishimatsu
2013-01-31 3:22 ` [RESEND PATCH 1/4] ACPI/PM: Fix acpi_bus_get_device() check in drivers/acpi/device_pm.c Yasuaki Ishimatsu
2013-01-31 20:21 ` Rafael J. Wysocki
2013-01-31 23:43 ` Yasuaki Ishimatsu
2013-02-01 22:30 ` Rafael J. Wysocki
2013-01-31 3:15 ` [PATCH 0/4] Fix acpi_bus_get_device() check Yasuaki Ishimatsu
2013-01-31 3:23 ` [RESEND PATCH 2/4] ACPI/dock: Fix acpi_bus_get_device() check in drivers/acpi/ddock.c Yasuaki Ishimatsu
2013-01-31 3:16 ` [PATCH 0/4] Fix acpi_bus_get_device() check Yasuaki Ishimatsu
2013-01-31 3:26 ` [RESEND PATCH 3/4] PNPACPI: Fix acpi_bus_get_device() check in drivers/pnp/pnpacpi/core.c Yasuaki Ishimatsu
2013-01-31 3:19 ` [PATCH 0/4] Fix acpi_bus_get_device() check Yasuaki Ishimatsu
2013-01-31 3:27 ` [RESEND PATCH 4/4] GPU/i915: Fix acpi_bus_get_device() check in drivers/gpu/drm/i915/intel_opregion.c Yasuaki Ishimatsu
2013-01-31 10:03 ` Daniel Vetter
2013-02-01 0:50 ` [UPDATE][PATCH " Yasuaki Ishimatsu
2013-02-01 0:53 ` Yasuaki Ishimatsu
2013-02-01 1:14 ` Yasuaki Ishimatsu
2013-02-01 10:03 ` Daniel Vetter
2013-01-31 8:45 ` [PATCH 1/2] ACPI / scan: Fix acpi_bus_get_device() check in acpi_match_device() Mika Westerberg
2013-01-31 18:38 ` Yinghai Lu
2013-01-30 22:04 ` [PATCH 2/2] ACPI / scan: Clean up acpi_bus_get_parent() Rafael J. Wysocki
2013-01-31 3:41 ` Yasuaki Ishimatsu
2013-01-31 8:46 ` Mika Westerberg
2013-01-31 18:43 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5109DF47.30305@jp.fujitsu.com \
--to=isimatu.yasuaki@jp.fujitsu.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rjw@sisk.pl \
--cc=toshi.kani@hp.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).