From: Maarten Lankhorst <maarten.lankhorst@canonical.com>
To: Borislav Petkov <bp@alien8.de>,
dri-devel@lists.freedesktop.org,
lkml <linux-kernel@vger.kernel.org>
Subject: [PATCH] drm/nouveau: always select ACPI_VIDEO if ACPI is enabled.
Date: Mon, 04 Feb 2013 16:41:22 +0100 [thread overview]
Message-ID: <510FD6A2.80101@canonical.com> (raw)
In-Reply-To: <20130204152344.GG13909@pd.tnic>
Hey,
Op 04-02-13 16:23, Borislav Petkov schreef:
> Hi,
>
> I'm guessing someone has already triggered this on latest Linus' tree
> and has a fix?
>
> drivers/built-in.o: In function `nouveau_acpi_edid':
> /w/kernel/linux/drivers/gpu/drm/nouveau/nouveau_acpi.c:420: undefined reference to `acpi_video_get_edid'
> make: *** [vmlinux] Error 1
>
> Btw, I got CONFIG_ACPI_VIDEO=m while CONFIG_DRM_NOUVEAU=y and this is
> probably the reason for the vmlinux link error.
>
> Thanks.
>
Does this fix things?
-->8
Having nouveau builtin would still allow ACPI_VIDEO to be used as external module if some of the deps for acpi_video
have not been met, which would result in a linking failure. Solve this by only requiring ACPI && X86 to select ACPI_VIDEO.
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@canonical.com>
---
diff --git a/drivers/gpu/drm/nouveau/Kconfig b/drivers/gpu/drm/nouveau/Kconfig
index 8a55bee..f08b9b6 100644
--- a/drivers/gpu/drm/nouveau/Kconfig
+++ b/drivers/gpu/drm/nouveau/Kconfig
@@ -10,7 +10,7 @@ config DRM_NOUVEAU
select FB
select FRAMEBUFFER_CONSOLE if !EXPERT
select FB_BACKLIGHT if DRM_NOUVEAU_BACKLIGHT
- select ACPI_VIDEO if ACPI && X86 && BACKLIGHT_CLASS_DEVICE && VIDEO_OUTPUT_CONTROL && INPUT
+ select ACPI_VIDEO if ACPI && X86
select ACPI_WMI if ACPI
select MXM_WMI if ACPI
select POWER_SUPPLY
next prev parent reply other threads:[~2013-02-04 15:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-04 15:23 drivers/gpu/drm/nouveau/nouveau_acpi.c:420: undefined reference to `acpi_video_get_edid' Borislav Petkov
2013-02-04 15:41 ` Maarten Lankhorst [this message]
2013-02-05 14:52 ` [PATCH] drm/nouveau: always select ACPI_VIDEO if ACPI is enabled Borislav Petkov
2013-02-05 15:38 ` [PATCH v2] " Maarten Lankhorst
2013-02-05 16:22 ` Borislav Petkov
2013-02-20 18:56 ` Borislav Petkov
2013-04-17 10:10 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=510FD6A2.80101@canonical.com \
--to=maarten.lankhorst@canonical.com \
--cc=bp@alien8.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).