From: Sergei Shtylyov <sshtylyov@mvista.com>
To: "Vishwanathrao Badarkhe, Manish" <manishv.b@ti.com>
Cc: linux-i2c@vger.kernel.org,
davinci-linux-open-source@linux.davincidsp.com,
linux-kernel@vger.kernel.org, w.sang@pengutronix.de,
ben-linux@fluff.org
Subject: Re: [PATCH V2] i2c: davinci: update to devm_* API
Date: Wed, 06 Feb 2013 15:51:36 +0400 [thread overview]
Message-ID: <511243C8.8060400@mvista.com> (raw)
In-Reply-To: <1360149736-32523-1-git-send-email-manishv.b@ti.com>
Hello.
On 06-02-2013 15:22, Vishwanathrao Badarkhe, Manish wrote:
> Update the code to use devm_* API so that driver
> core will manage resources.
> Signed-off-by: Vishwanathrao Badarkhe, Manish <manishv.b@ti.com>
> ---
> Changes since V1:
> - Rebase on top of v3.8-rc6 of linus tree.
> - Apply devm operation on clk_get.
> :100644 100644 6a0a553... da4e218... M drivers/i2c/busses/i2c-davinci.c
> drivers/i2c/busses/i2c-davinci.c | 45 +++++++++++---------------------------
> 1 files changed, 13 insertions(+), 32 deletions(-)
> diff --git a/drivers/i2c/busses/i2c-davinci.c b/drivers/i2c/busses/i2c-davinci.c
> index 6a0a553..da4e218 100644
> --- a/drivers/i2c/busses/i2c-davinci.c
> +++ b/drivers/i2c/busses/i2c-davinci.c
[...]
> @@ -699,22 +693,24 @@ static int davinci_i2c_probe(struct platform_device *pdev)
> dev->pdata = &davinci_i2c_platform_data_default;
> }
>
> - dev->clk = clk_get(&pdev->dev, NULL);
> + dev->clk = devm_clk_get(&pdev->dev, NULL);
> if (IS_ERR(dev->clk)) {
> r = -ENODEV;
> goto err_free_mem;
> }
> clk_prepare_enable(dev->clk);
>
> - dev->base = ioremap(mem->start, resource_size(mem));
> + dev->base = devm_request_and_ioremap(&pdev->dev, mem);
> if (!dev->base) {
> r = -EBUSY;
Comment to devm_request_and_ioremap() suggests returning -EADDRNOTAVAIL on
failure. -EBUSY wasn't the right code even before this change, should have
been -ENOMEM.
WBR, Sergei
next prev parent reply other threads:[~2013-02-06 11:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-06 11:22 [PATCH V2] i2c: davinci: update to devm_* API Vishwanathrao Badarkhe, Manish
2013-02-06 11:51 ` Sergei Shtylyov [this message]
2013-02-07 3:02 ` Vishwanathrao Badarkhe, Manish
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=511243C8.8060400@mvista.com \
--to=sshtylyov@mvista.com \
--cc=ben-linux@fluff.org \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manishv.b@ti.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).