From: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
To: Toshi Kani <toshi.kani@hp.com>
Cc: <rjw@sisk.pl>, <linux-acpi@vger.kernel.org>,
<gregkh@linuxfoundation.org>, <bhelgaas@google.com>,
<mika.westerberg@linux.intel.com>, <matthew.garrett@nebula.com>,
<yinghai@kernel.org>, <liuj97@gmail.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 01/02] ACPI: sysfs eject support for ACPI scan handlers
Date: Fri, 8 Feb 2013 10:33:07 +0900 [thread overview]
Message-ID: <511455D3.6020602@jp.fujitsu.com> (raw)
In-Reply-To: <1360285813.3869.52.camel@misato.fc.hp.com>
2013/02/08 10:10, Toshi Kani wrote:
> On Fri, 2013-02-08 at 09:50 +0900, Yasuaki Ishimatsu wrote:
>> Hi Toshi,
>>
>> 2013/02/07 7:50, Toshi Kani wrote:
>>> Changed sysfs eject, acpi_eject_store(), to support ACPI scan handlers.
>>>
>>> Signed-off-by: Toshi Kani <toshi.kani@hp.com>
>>> ---
>>> drivers/acpi/scan.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c
>>> index cfd7a69..3ff632e 100644
>>> --- a/drivers/acpi/scan.c
>>> +++ b/drivers/acpi/scan.c
>>> @@ -203,7 +203,7 @@ acpi_eject_store(struct device *d, struct device_attribute *attr,
>>> return -EINVAL;
>>> }
>>> #ifndef FORCE_EJECT
>>
>>> - if (acpi_device->driver == NULL) {
>>> + if (!acpi_device->driver && !acpi_device->handler) {
>>
>> I don't understand the fix.
>>
>> The if sentence becomes true, when both acpi_device->driver and acpi_device->handler
>> are NULL. It means that acpi_eject_store() runs if either acpi_device->driver or
>> acpi_device->handler has pointer. Is it O.K.?
>
> Yes.
>
>> I think it should be if (!acpi_device->driver || !acpi_device->handler).
>
> No, the condition has to be "&&" because an acpi_device is _either_
> bound to an ACPI driver or an ACPI scan handler.
Thank you for you clarification. I understood it.
Acked-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
Thanks,
Yasuaki Ishimatsu
>
> Thanks,
> -Toshi
>
>
next prev parent reply other threads:[~2013-02-08 1:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-06 22:50 [PATCH 00/02] ACPI: sysfs eject support for container Toshi Kani
2013-02-06 22:50 ` [PATCH 01/02] ACPI: sysfs eject support for ACPI scan handlers Toshi Kani
2013-02-08 0:50 ` Yasuaki Ishimatsu
2013-02-08 1:10 ` Toshi Kani
2013-02-08 1:33 ` Yasuaki Ishimatsu [this message]
2013-02-08 1:25 ` Toshi Kani
2013-02-06 22:50 ` [PATCH 02/02] ACPI: Register container drv as scan driver Toshi Kani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=511455D3.6020602@jp.fujitsu.com \
--to=isimatu.yasuaki@jp.fujitsu.com \
--cc=bhelgaas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuj97@gmail.com \
--cc=matthew.garrett@nebula.com \
--cc=mika.westerberg@linux.intel.com \
--cc=rjw@sisk.pl \
--cc=toshi.kani@hp.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).