From: Sekhar Nori <nsekhar@ti.com>
To: "Kumar, Anil" <anilkumar.v@ti.com>
Cc: "linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"davinci-linux-open-source@linux.davincidsp.com"
<davinci-linux-open-source@linux.davincidsp.com>,
"wim@iguana.be" <wim@iguana.be>
Subject: Re: [PATCH] watchdog: davinci_wdt: update to devm_* API
Date: Fri, 8 Feb 2013 09:49:27 +0530 [thread overview]
Message-ID: <51147CCF.7050100@ti.com> (raw)
In-Reply-To: <F3DBB1B3EF102E4994C89758CFCA32412C59CA@DBDE01.ent.ti.com>
On 2/8/2013 8:05 AM, Kumar, Anil wrote:
> On Thu, Feb 07, 2013 at 23:20:48, Nori, Sekhar wrote:
>> On 2/7/2013 9:02 AM, Kumar, Anil wrote:
>>> Update the code to use devm_* API so that driver
>>> core will manage resources.
>>> Signed-off-by: Kumar, Anil <anilkumar.v@ti.com>
>>> diff --git a/drivers/watchdog/davinci_wdt.c b/drivers/watchdog/davinci_wdt.c
>>> @@ -201,10 +200,10 @@ static struct miscdevice davinci_wdt_miscdev = {
>>>
>>> static int davinci_wdt_probe(struct platform_device *pdev)
>>> {
>>> - int ret = 0, size;
>>> - struct device *dev = &pdev->dev;
>>
>> Its not clear why you had to drop use of this variable?
>
> Actually, I have not found any particular need to take pointer
> into dev and then use in the code. Rather we can directly use.
No, it is good enough as-is. It will help rid your patch of unnecessary
changes and its not really convenient to to keep reading &pdev->dev all
the time.
Thanks,
Sekhar
next prev parent reply other threads:[~2013-02-08 4:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-07 3:32 [PATCH] watchdog: davinci_wdt: update to devm_* API Kumar, Anil
2013-02-07 11:21 ` Sergei Shtylyov
2013-02-08 2:19 ` Kumar, Anil
2013-02-07 17:50 ` Sekhar Nori
2013-02-08 2:35 ` Kumar, Anil
2013-02-08 4:19 ` Sekhar Nori [this message]
2013-02-08 4:21 ` Kumar, Anil
2013-02-08 5:37 ` Kumar, Anil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51147CCF.7050100@ti.com \
--to=nsekhar@ti.com \
--cc=anilkumar.v@ti.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).