From: "André Hentschel" <nerv@dawncrow.de>
To: Will Deacon <will.deacon@arm.com>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Greg KH <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] arm: Preserve TPIDRURW on context switch
Date: Sat, 09 Feb 2013 17:44:21 +0100 [thread overview]
Message-ID: <51167CE5.6060303@dawncrow.de> (raw)
In-Reply-To: <20130208154809.GF3495@mudshark.cambridge.arm.com>
Am 08.02.2013 16:48, schrieb Will Deacon:
> On Wed, Feb 06, 2013 at 11:01:23PM +0000, André Hentschel wrote:
>> Am 06.02.2013 23:51, schrieb Russell King - ARM Linux:
>>> On Wed, Feb 06, 2013 at 11:43:10PM +0100, André Hentschel wrote:
>>>> There are more and more applications coming to WinRT, Wine could support them,
>>>> but mostly they expect to have the thread environment block (TEB) in TPIDRURW.
>>>> This register must be preserved per thread instead of being cleared.
>>>
>>> I'd prefer this was done a little more sensitively to those CPUs where
>>> loads/stores are expensive, namely:
>>>
>>>> +
>>>> + @ preserve TPIDRURW register state
>>>> + get_tls2 r3, r4, r5
>>>> + str r3, [r1, #TI_TP2_VALUE]
>>>> + ldr r3, [r2, #TI_TP2_VALUE]
>>>> + set_tls2 r3, r4, r5
>>>
>>> those two loads/stores get omitted from the thread switching if the CPU
>>> doesn't support it. Do you think that's something you could do?
>>
>> No, i'm not sure how to improve this. How does the process can continue, can you or someone else fix that and add his Signed-off-by?
>
> How about something like the (completely untested) diff below?
>
> Andre: if this works for you, I'm happy to write a commit message etc.
>
> Cheers,
>
> Will
>
> --->8
I'll try the next days and report back, thx.
--
Best Regards, André Hentschel
next prev parent reply other threads:[~2013-02-09 16:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-06 22:43 [PATCH] arm: Preserve TPIDRURW on context switch André Hentschel
2013-02-06 22:51 ` Russell King - ARM Linux
2013-02-06 23:01 ` André Hentschel
2013-02-08 15:48 ` Will Deacon
2013-02-09 16:44 ` André Hentschel [this message]
2013-02-12 14:02 ` André Hentschel
2013-02-12 14:09 ` Will Deacon
2013-02-12 14:14 ` André Hentschel
2013-02-12 15:02 ` Matthieu CASTET
2013-02-20 19:34 ` André Hentschel
2013-02-21 10:33 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51167CE5.6060303@dawncrow.de \
--to=nerv@dawncrow.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).