From: Len Brown <lenb@kernel.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Len Brown <len.brown@intel.com>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
sparclinux@vger.kernel.org
Subject: Re: linux-next: build failure after merge of the final tree (acpi tree related)
Date: Mon, 11 Feb 2013 18:23:55 -0500 [thread overview]
Message-ID: <51197D8B.6010407@kernel.org> (raw)
In-Reply-To: <20130211183409.7519b73ca320baeac5ec886f@canb.auug.org.au>
On 02/11/2013 02:34 AM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the final tree, today's linux-next build (sparc64 defconfig)
> failed like this:
>
> arch/sparc/include/asm/processor.h: Assembler messages:
> arch/sparc/include/asm/processor.h:10: Error: Unknown opcode: `extern'
>
> Caused by commit 3a242f58a5f4 ("sparc idle: rename pm_idle to
> sparc_idle") from the acpi tree.
>
> I have applied this patch for today:
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Mon, 11 Feb 2013 18:30:19 +1100
> Subject: [PATCH] sparc idle: protect variable declarations against the assembler
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
> arch/sparc/include/asm/processor.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/sparc/include/asm/processor.h b/arch/sparc/include/asm/processor.h
> index 34baa35..622cfa5 100644
> --- a/arch/sparc/include/asm/processor.h
> +++ b/arch/sparc/include/asm/processor.h
> @@ -7,6 +7,8 @@
> #endif
>
> #define nop() __asm__ __volatile__ ("nop")
> +#ifndef __ASSEMBLY__
> extern void (*sparc_idle)(void);
> +#endif
>
> #endif
>
Thank you Stephen!
The last time I compiled a sparc kernel was in 1993:-)
I've added your fix and Dave's Ack to this patch,
and updated it in my next branch.
Len Brown, Intel Open Source Technology Center
next prev parent reply other threads:[~2013-02-11 23:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-11 7:34 linux-next: build failure after merge of the final tree (acpi tree related) Stephen Rothwell
2013-02-11 18:22 ` Bjorn Helgaas
2013-02-11 23:23 ` Len Brown [this message]
2013-02-12 17:35 ` Sam Ravnborg
2013-02-12 18:01 ` Should SPARC use cpuidle? (was: linux-next: build failure after merge of the final tree (acpi tree related)) Len Brown
2013-02-12 18:03 ` Should SPARC use cpuidle? Len Brown
2013-02-12 19:36 ` Sam Ravnborg
2013-02-12 19:42 ` Should SPARC use cpuidle? (was: linux-next: build failure after merge of the final tree (acpi tree related)) Sam Ravnborg
-- strict thread matches above, loose matches on Subject: below --
2010-05-24 3:41 linux-next: build failure after merge of the final tree (acpi tree related) Stephen Rothwell
2010-05-24 6:31 ` Len Brown
2010-05-24 7:41 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51197D8B.6010407@kernel.org \
--to=lenb@kernel.org \
--cc=davem@davemloft.net \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).