From: Stephen Warren <swarren@wwwdotorg.org>
To: Joe Perches <joe@perches.com>
Cc: arm@kernel.org, linux-tegra@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Julian Andres Klode <jak@jak-linux.org>,
Marc Dietrich <marvin24@gmx.de>,
Stephen Warren <swarren@nvidia.com>
Subject: Re: [PATCH V4 1/2] get_maintainer: allow keywords to match filenames
Date: Tue, 12 Feb 2013 11:17:39 -0700 [thread overview]
Message-ID: <511A8743.9010408@wwwdotorg.org> (raw)
In-Reply-To: <1360649875.5128.18.camel@joe-AO722>
On 02/11/2013 11:17 PM, Joe Perches wrote:
> On Mon, 2013-02-11 at 17:39 -0700, Stephen Warren wrote:
>> From: Stephen Warren <swarren@nvidia.com>
>>
>> Allow K: entries in MAINTAINERS to match directly against filenames;
>> either those extracted from patch +++ or --- lines, or those specified
>> on the command-line using the -f option.
> []
>> diff --git a/MAINTAINERS b/MAINTAINERS
> []
>> @@ -97,12 +97,12 @@ Descriptions of section entries:
>> X: net/ipv6/
>> matches all files in and below net excluding net/ipv6/
>> K: Keyword perl extended regex pattern to match content in a
>> - patch or file. For instance:
>> + patch, or an affected filename. For instance:
>
> The removal of file isn't correct.
>
> This should read "patch, file or filename".
>
> If the -f pattern is a single file,
> get_maintainer reads that file content and then
> matches any K: patterns.
>
> When the -f pattern is a directory, it doesn't.
Yes, I guess that's true; I had convinced myself that "file" wasn't
accurate since "-f directory/" didn't scan the files within that
directory tree, but as you say "-f file" does scan the file content.
BTW, given I'm adding "filename" to the list, I intend to change the
existing "file" to "file content" to be clear. Are you OK with that?
next prev parent reply other threads:[~2013-02-12 18:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-12 0:39 [PATCH V4 1/2] get_maintainer: allow keywords to match filenames Stephen Warren
2013-02-12 0:39 ` [PATCH V4 2/2] MAINTAINERS: update Tegra section to capture all Tegra files Stephen Warren
2013-02-25 20:56 ` Stephen Warren
2013-02-12 6:17 ` [PATCH V4 1/2] get_maintainer: allow keywords to match filenames Joe Perches
2013-02-12 18:17 ` Stephen Warren [this message]
2013-02-12 18:22 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=511A8743.9010408@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=arm@kernel.org \
--cc=jak@jak-linux.org \
--cc=joe@perches.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=marvin24@gmx.de \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).