From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
Kyungmin Park <kyungmin.park@samsung.com>,
Liam Girdwood <lrg@ti.com>, Chris Ball <cjb@laptop.org>,
Kevin Liu <keyuan.liu@gmail.com>
Subject: Re: [PATCH 3/3 RESEND] mmc: sdhci: check voltage range only on regulators aware of voltage value
Date: Thu, 14 Feb 2013 09:05:43 +0100 [thread overview]
Message-ID: <511C9AD7.6000904@samsung.com> (raw)
In-Reply-To: <20130213113525.GB5062@opensource.wolfsonmicro.com>
On 2/13/2013 12:35 PM, Mark Brown wrote:
> On Wed, Feb 13, 2013 at 08:45:56AM +0100, Guennadi Liakhovetski wrote:
> > On Wed, 13 Feb 2013, Marek Szyprowski wrote:
>
> > > BTW, mmc_regulator_get_ocrmask() won't work with continuous range regulators.
>
> > This seems like a problem, that has to be fixed...
>
> Indeed, what's the issue?
There are probably 2 issues:
1. mmc_regulator_get_ocrmask() works only with regulators which support
regulator_count_voltages() and regulator_list_voltage(). Recently
support for
continuous regulators have been merged. Such regulators doesn't provide
regulator_list_voltage() method, but are able to change/set voltage to the
given value. I agree that they are not very common, so right now we can
probably ignore them until the first board, which uses them arrives.
2. The second issue might be related to the testing of precise voltage
values
in the ocr mask, not the whole allowed ranges. Such issues in sdhci.c
driver
has been recently fixed by commit cec2e216f72c6b5ccdadb60aadbe99821d744503
("mmc: sdhci: Use regulator min/max voltage range according to spec"), but I
don't know MMC core code to judge if ocr mask is used for exact voltage
checking or only for checking the voltage ranges. However someone with good
mmc subsystem knowledge should check it.
Best regards
--
Marek Szyprowski
Samsung Poland R&D Center
next prev parent reply other threads:[~2013-02-14 8:05 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-04 14:01 [PATCH v2 0/3] Fix fixed regulators support Marek Szyprowski
2012-12-04 14:01 ` [PATCH 1/3] regulators: add regulator_can_change_voltage() function Marek Szyprowski
2012-12-06 6:18 ` Mark Brown
2012-12-04 14:01 ` [PATCH 2/3] mmc: use regulator_can_change_voltage() instead of regulator_count_voltages() hacks Marek Szyprowski
2013-02-01 14:39 ` Marek Szyprowski
2013-02-11 17:26 ` Chris Ball
2012-12-04 14:01 ` [PATCH 3/3] mmc: sdhci: check voltage range only on regulators aware of voltage value Marek Szyprowski
2012-12-04 14:50 ` Kevin Liu
2012-12-05 1:48 ` Mark Brown
2012-12-05 2:12 ` Kevin Liu
2013-02-01 14:40 ` Marek Szyprowski
2013-02-11 17:27 ` Chris Ball
2013-02-12 8:01 ` [PATCH 3/3 RESEND] " Marek Szyprowski
2013-02-12 22:10 ` Guennadi Liakhovetski
2013-02-13 7:33 ` Marek Szyprowski
2013-02-13 7:45 ` Guennadi Liakhovetski
2013-02-13 11:35 ` Mark Brown
2013-02-14 8:05 ` Marek Szyprowski [this message]
2013-02-14 11:03 ` Mark Brown
2013-02-14 11:08 ` Ulf Hansson
2013-02-20 9:34 ` Kevin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=511C9AD7.6000904@samsung.com \
--to=m.szyprowski@samsung.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=cjb@laptop.org \
--cc=g.liakhovetski@gmx.de \
--cc=keyuan.liu@gmail.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).