From: Pavel Emelyanov <xemul@parallels.com>
To: mtk.manpages@gmail.com, Oleg Nesterov <oleg@redhat.com>
Cc: Andrey Vagin <avagin@openvz.org>,
linux-kernel@vger.kernel.org, criu@openvz.org,
linux-api@vger.kernel.org, Roland McGrath <roland@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
David Howells <dhowells@redhat.com>,
Dave Jones <davej@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] ptrace: add ability to retrieve signals without removing them from a queue
Date: Tue, 19 Feb 2013 21:53:36 +0400 [thread overview]
Message-ID: <5123BC20.9040405@parallels.com> (raw)
In-Reply-To: <CAKgNAkicAGEkvNFnSso__wK6QKao8jyDu5yuRmeyUOeaXLGChw@mail.gmail.com>
On 02/19/2013 04:15 PM, Michael Kerrisk (man-pages) wrote:
> On Wed, Feb 13, 2013 at 4:16 PM, Andrey Vagin <avagin@openvz.org> wrote:
>> This patch adds a new ptrace request PTRACE_PEEKSIGINFO.
>>
>> This request is used to retrieve information about a signal with the
>> specified sequence number. A siginfo_t structure is copied from the child
>> to location data in the parent.
>>
>> The low 16 bits of addr contains a sequence number of signal in a queue:
>
> I think 16 bits is probably not enough.... Already, on the "out of the
> box" system that I have at hand, one can queue more than 2^16-1
> signals:
>
> $ cat /proc/$$/status | grep SigQ
> SigQ: 2/126065
Yup :( Well, actually it would be enough to have only 1 bit as "flags"
and the rest (31 at least) for the number. But taking into account
Oleg's wish to have an ability to extend the amount of flags in the
future, we should make addr point to something like
struct siginfo_peek_options {
unsigned int flags;
unsigned int pos;
};
and force flags to contain zero in all the bits but one, and this
latter bit is to select between private or shared queue. In this case
the patch loses its main advantage -- the simplicity.
Oleg, please, suggest which way would be more preferable?
> Cheers,
>
> Michael
next prev parent reply other threads:[~2013-02-19 17:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-13 15:16 [PATCH] ptrace: add ability to retrieve signals without removing them from a queue Andrey Vagin
2013-02-13 16:06 ` Oleg Nesterov
2013-02-15 18:44 ` Pedro Alves
2013-02-15 19:43 ` Oleg Nesterov
2013-02-15 19:53 ` Pedro Alves
2013-02-15 20:03 ` Pedro Alves
2013-02-19 9:39 ` Andrey Wagin
2013-02-19 12:15 ` Michael Kerrisk (man-pages)
2013-02-19 17:53 ` Pavel Emelyanov [this message]
2013-02-19 19:34 ` Oleg Nesterov
2013-02-19 19:47 ` Pavel Emelyanov
2013-02-20 22:37 ` Oleg Nesterov
2013-02-21 10:30 ` Pavel Emelyanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5123BC20.9040405@parallels.com \
--to=xemul@parallels.com \
--cc=akpm@linux-foundation.org \
--cc=avagin@openvz.org \
--cc=criu@openvz.org \
--cc=davej@redhat.com \
--cc=dhowells@redhat.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
--cc=oleg@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=roland@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).