From: Wanlong Gao <gaowanlong@cn.fujitsu.com>
To: Jason Wang <jasowang@redhat.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
Paolo Bonzini <pbonzini@redhat.com>,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH 10/16] virtio_net: use virtqueue_add_sgs[] for command buffers.
Date: Thu, 21 Feb 2013 17:43:44 +0800 [thread overview]
Message-ID: <5125EC50.7020401@cn.fujitsu.com> (raw)
In-Reply-To: <5125EBC8.1000309@redhat.com>
On 02/21/2013 05:41 PM, Jason Wang wrote:
> On 02/21/2013 04:30 PM, Wanlong Gao wrote:
>> On 02/19/2013 03:56 PM, Rusty Russell wrote:
>>> It's a bit cleaner to hand multiple sgs, rather than one big one.
>>>
>>> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
>>> ---
>>> drivers/net/virtio_net.c | 50 ++++++++++++++++++++++------------------------
>>> 1 file changed, 24 insertions(+), 26 deletions(-)
>>>
>>> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
>>> index 8ca69c0..63ac5c1 100644
>>> --- a/drivers/net/virtio_net.c
>>> +++ b/drivers/net/virtio_net.c
>>> @@ -39,7 +39,6 @@ module_param(gso, bool, 0444);
>>> #define MAX_PACKET_LEN (ETH_HLEN + VLAN_HLEN + ETH_DATA_LEN)
>>> #define GOOD_COPY_LEN 128
>>>
>>> -#define VIRTNET_SEND_COMMAND_SG_MAX 2
>>> #define VIRTNET_DRIVER_VERSION "1.0.0"
>>>
>>> struct virtnet_stats {
>>> @@ -831,32 +830,32 @@ static void virtnet_netpoll(struct net_device *dev)
>>> * never fail unless improperly formated.
>>> */
>>> static bool virtnet_send_command(struct virtnet_info *vi, u8 class, u8 cmd,
>>> - struct scatterlist *data, int out, int in)
>>> + struct scatterlist *out,
>>> + struct scatterlist *in)
>>> {
>>> - struct scatterlist *s, sg[VIRTNET_SEND_COMMAND_SG_MAX + 2];
>>> + struct scatterlist *sgs[4], hdr, stat;
>>> struct virtio_net_ctrl_hdr ctrl;
>>> virtio_net_ctrl_ack status = ~0;
>>> - unsigned int tmp;
>>> - int i;
>>> + unsigned out_num = 0, in_num = 0, tmp;
>>>
>>> /* Caller should know better */
>>> - BUG_ON(!virtio_has_feature(vi->vdev, VIRTIO_NET_F_CTRL_VQ) ||
>>> - (out + in > VIRTNET_SEND_COMMAND_SG_MAX));
>>> -
>>> - out++; /* Add header */
>>> - in++; /* Add return status */
>>> + BUG_ON(!virtio_has_feature(vi->vdev, VIRTIO_NET_F_CTRL_VQ));
>>>
>>> - ctrl.class = class;
>>> - ctrl.cmd = cmd;
>
> Looks like typos here, those should be kept.
Yes, I already fixed this here but the warning shows as well.
Thanks,
Wanlong Gao
>>> + /* Add header */
>>> + sg_init_one(&hdr, &ctrl, sizeof(ctrl));
>>> + sgs[out_num++] = &hdr;
>>>
>>> - sg_init_table(sg, out + in);
>>> + if (out)
>>> + sgs[out_num++] = out;
>>> + if (in)
>>> + sgs[out_num + in_num++] = in;
>>>
>>> - sg_set_buf(&sg[0], &ctrl, sizeof(ctrl));
>>> - for_each_sg(data, s, out + in - 2, i)
>>> - sg_set_buf(&sg[i + 1], sg_virt(s), s->length);
>>> - sg_set_buf(&sg[out + in - 1], &status, sizeof(status));
>>> + /* Add return status. */
>>> + sg_init_one(&stat, &status, sizeof(status));
>>> + sgs[out_num + in_num++] = &hdr;
>>>
>>> - BUG_ON(virtqueue_add_buf(vi->cvq, sg, out, in, vi, GFP_ATOMIC) < 0);
>>> + BUG_ON(virtqueue_add_sgs(vi->cvq, sgs, out_num, in_num, vi, GFP_ATOMIC)
>>> + < 0);
>>>
>>> virtqueue_kick(vi->cvq);
>>>
>>> @@ -874,8 +873,7 @@ static void virtnet_ack_link_announce(struct virtnet_info *vi)
>>> {
>>> rtnl_lock();
>>> if (!virtnet_send_command(vi, VIRTIO_NET_CTRL_ANNOUNCE,
>>> - VIRTIO_NET_CTRL_ANNOUNCE_ACK, NULL,
>>> - 0, 0))
>>> + VIRTIO_NET_CTRL_ANNOUNCE_ACK, NULL, NULL))
>>> dev_warn(&vi->dev->dev, "Failed to ack link announce.\n");
>>> rtnl_unlock();
>>> }
>>> @@ -893,7 +891,7 @@ static int virtnet_set_queues(struct virtnet_info *vi, u16 queue_pairs)
>>> sg_init_one(&sg, &s, sizeof(s));
>>>
>>> if (!virtnet_send_command(vi, VIRTIO_NET_CTRL_MQ,
>>> - VIRTIO_NET_CTRL_MQ_VQ_PAIRS_SET, &sg, 1, 0)){
>>> + VIRTIO_NET_CTRL_MQ_VQ_PAIRS_SET, &sg, NULL)) {
>>> dev_warn(&dev->dev, "Fail to set num of queue pairs to %d\n",
>>> queue_pairs);
>>> return -EINVAL;
>>> @@ -940,7 +938,7 @@ static void virtnet_set_rx_mode(struct net_device *dev)
>>>
>>> if (!virtnet_send_command(vi, VIRTIO_NET_CTRL_RX,
>>> VIRTIO_NET_CTRL_RX_PROMISC,
>>> - sg, 1, 0))
>>> + sg, NULL))
>>> dev_warn(&dev->dev, "Failed to %sable promisc mode.\n",
>>> promisc ? "en" : "dis");
>>>
>>> @@ -948,7 +946,7 @@ static void virtnet_set_rx_mode(struct net_device *dev)
>>>
>>> if (!virtnet_send_command(vi, VIRTIO_NET_CTRL_RX,
>>> VIRTIO_NET_CTRL_RX_ALLMULTI,
>>> - sg, 1, 0))
>>> + sg, NULL))
>>> dev_warn(&dev->dev, "Failed to %sable allmulti mode.\n",
>>> allmulti ? "en" : "dis");
>>>
>>> @@ -987,7 +985,7 @@ static void virtnet_set_rx_mode(struct net_device *dev)
>>>
>>> if (!virtnet_send_command(vi, VIRTIO_NET_CTRL_MAC,
>>> VIRTIO_NET_CTRL_MAC_TABLE_SET,
>>> - sg, 2, 0))
>>> + sg, NULL))
>>> dev_warn(&dev->dev, "Failed to set MAC fitler table.\n");
>>
>> After applied this patch, I got the warning messages:
>>
>> [ 7.545454] net eth0: Failed to disable promisc mode.
>> [ 7.546243] net eth0: Failed to disable allmulti mode.
>> [ 7.546990] net eth0: Failed to set MAC fitler table.
>> [ 7.547940] net eth0: Failed to disable promisc mode.
>> [ 7.548840] net eth0: Failed to disable allmulti mode.
>> [ 7.549744] net eth0: Failed to set MAC fitler table.
>> [ 7.550705] net eth0: Failed to disable promisc mode.
>> [ 7.551603] net eth0: Failed to disable allmulti mode.
>> [ 7.552504] net eth0: Failed to set MAC fitler table.
>> [ 7.553423] net eth0: Failed to disable promisc mode.
>> [ 7.554308] net eth0: Failed to disable allmulti mode.
>> [ 7.555201] net eth0: Failed to set MAC fitler table.
>> [ 9.571103] net eth0: Failed to disable promisc mode.
>> [ 9.572948] net eth0: Failed to disable allmulti mode.
>> [ 9.574598] net eth0: Failed to set MAC fitler table.
>> network[476]: Bringing up interface eth0: [ OK ]
>> [ 9.905455] net eth0: Failed to disable promisc mode.
>> [ 9.906465] net eth0: Failed to disable allmulti mode.
>> [ 9.907234] net eth0: Failed to set MAC fitler table.
>>
>>
>> Any thoughts?
>>
>>
>> Thanks,
>> Wanlong Gao
>>
>>>
>>> kfree(buf);
>>> @@ -1001,7 +999,7 @@ static int virtnet_vlan_rx_add_vid(struct net_device *dev, u16 vid)
>>> sg_init_one(&sg, &vid, sizeof(vid));
>>>
>>> if (!virtnet_send_command(vi, VIRTIO_NET_CTRL_VLAN,
>>> - VIRTIO_NET_CTRL_VLAN_ADD, &sg, 1, 0))
>>> + VIRTIO_NET_CTRL_VLAN_ADD, &sg, NULL))
>>> dev_warn(&dev->dev, "Failed to add VLAN ID %d.\n", vid);
>>> return 0;
>>> }
>>> @@ -1014,7 +1012,7 @@ static int virtnet_vlan_rx_kill_vid(struct net_device *dev, u16 vid)
>>> sg_init_one(&sg, &vid, sizeof(vid));
>>>
>>> if (!virtnet_send_command(vi, VIRTIO_NET_CTRL_VLAN,
>>> - VIRTIO_NET_CTRL_VLAN_DEL, &sg, 1, 0))
>>> + VIRTIO_NET_CTRL_VLAN_DEL, &sg, NULL))
>>> dev_warn(&dev->dev, "Failed to kill VLAN ID %d.\n", vid);
>>> return 0;
>>> }
>>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at http://www.tux.org/lkml/
>
>
next prev parent reply other threads:[~2013-02-21 9:44 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-19 7:56 [PATCH 00/16] virtio ring rework Rusty Russell
2013-02-19 7:56 ` [PATCH 01/16] scatterlist: introduce sg_unmark_end Rusty Russell
2013-02-19 7:56 ` [PATCH 02/16] virtio_ring: virtqueue_add_sgs, to add multiple sgs Rusty Russell
2013-02-19 9:15 ` Wanlong Gao
2013-02-20 9:18 ` Asias He
2013-02-24 22:12 ` Michael S. Tsirkin
2013-02-26 5:14 ` Rusty Russell
2013-02-26 9:30 ` Michael S. Tsirkin
2013-02-26 7:02 ` Paolo Bonzini
2013-02-27 7:28 ` Rusty Russell
2013-02-27 7:49 ` Michael S. Tsirkin
2013-02-27 11:21 ` Rusty Russell
2013-02-28 9:24 ` Paolo Bonzini
2013-03-01 1:01 ` Rusty Russell
2013-02-19 7:56 ` [PATCH 03/16] virtio-blk: reorganize virtblk_add_req Rusty Russell
2013-02-19 7:56 ` [PATCH 04/16] virtio-blk: use virtqueue_start_buf on bio path Rusty Russell
2013-02-20 9:19 ` Asias He
2013-02-21 6:23 ` Rusty Russell
2013-02-19 7:56 ` [PATCH 05/16] virtio-blk: use virtqueue_add_sgs on req path Rusty Russell
2013-02-20 9:20 ` Asias He
2013-02-19 7:56 ` [PATCH 06/16] virtio_blk: remove nents member Rusty Russell
2013-02-20 9:20 ` Asias He
2013-02-19 7:56 ` [PATCH 07/16] virtio_ring: don't count elements twice for add_buf path Rusty Russell
2013-02-20 10:09 ` Wanlong Gao
2013-02-19 7:56 ` [PATCH 08/16] virtio_ring: virtqueue_add_outbuf / virtqueue_add_inbuf Rusty Russell
2013-02-20 10:09 ` Wanlong Gao
2013-02-21 17:09 ` Michael S. Tsirkin
2013-02-22 0:02 ` Rusty Russell
2013-02-25 21:35 ` Michael S. Tsirkin
2013-02-28 5:08 ` Rusty Russell
2013-02-28 7:01 ` Michael S. Tsirkin
2013-03-06 6:03 ` Rusty Russell
2013-02-19 7:56 ` [PATCH 09/16] virtio_net: use simplified virtqueue accessors Rusty Russell
2013-02-20 10:09 ` Wanlong Gao
2013-02-19 7:56 ` [PATCH 10/16] virtio_net: use virtqueue_add_sgs[] for command buffers Rusty Russell
2013-02-20 10:11 ` Wanlong Gao
2013-02-21 6:27 ` Rusty Russell
2013-02-21 8:30 ` Wanlong Gao
2013-02-21 9:41 ` Jason Wang
2013-02-21 9:43 ` Wanlong Gao [this message]
2013-02-19 7:56 ` [PATCH 11/16] virtio_rng: use simplified virtqueue accessors Rusty Russell
2013-02-20 10:12 ` Wanlong Gao
2013-02-19 7:56 ` [PATCH 12/16] virtio_console: " Rusty Russell
2013-02-20 10:12 ` Wanlong Gao
2013-02-19 7:56 ` [PATCH 13/16] caif_virtio: " Rusty Russell
2013-02-20 10:13 ` Wanlong Gao
2013-02-19 7:56 ` [PATCH 14/16] virtio_rpmsg_bus: " Rusty Russell
2013-02-20 10:14 ` Wanlong Gao
2013-02-19 7:56 ` [PATCH 15/16] virtio_balloon: " Rusty Russell
2013-02-20 10:15 ` Wanlong Gao
2013-02-19 7:56 ` [PATCH 16/16] 9p/trans_virtio.c: use virtio_add_sgs[] Rusty Russell
2013-02-19 9:15 ` [PATCH 00/16] virtio ring rework Paolo Bonzini
2013-02-21 6:30 ` Rusty Russell
2013-02-20 8:37 ` [PATCH 17/16] virtio-scsi: use virtqueue_add_sgs for command buffers Wanlong Gao
2013-02-20 9:38 ` Asias He
2013-02-20 9:41 ` Wanlong Gao
2013-02-20 9:47 ` [PATCH 17/16 V2] " Wanlong Gao
2013-02-20 10:54 ` Paolo Bonzini
2013-02-20 12:17 ` Asias He
2013-02-21 6:34 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5125EC50.7020401@cn.fujitsu.com \
--to=gaowanlong@cn.fujitsu.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).