From: Li Zefan <lizefan@huawei.com>
To: Tejun Heo <tj@kernel.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
LKML <linux-kernel@vger.kernel.org>,
Cgroups <cgroups@vger.kernel.org>
Subject: Re: [PATCH 2/3] cgroup: add cgroup_name() API
Date: Wed, 27 Feb 2013 18:49:12 +0800 [thread overview]
Message-ID: <512DE4A8.5050303@huawei.com> (raw)
In-Reply-To: <CAOS58YMb7HRQ3X+Z92vi3+jKr4DuNmAgxtc5e3Jkhy-s-7Os-g@mail.gmail.com>
On 2013/2/26 21:26, Tejun Heo wrote:
> Hello,
>
> On Tue, Feb 26, 2013 at 2:25 AM, Li Zefan <lizefan@huawei.com> wrote:
>> Sure we can. We'll have to allocate cgrp->name in cgroup_remount() and
>> cgroup_init(), and free cgrp->name in cgroup_kill_sb(). It looks to me
>> the current version is a bit simpler.
>
> Can't we just set it to constant "/"? Root cgroup init is a separate
> path anyway.
>
Well, cgrp->name is a pointer to struct cgroup_name.
At first I tried to declare cgrp->name as char *, and use container_of()
to get struct cgroup_name, but it didn't result in simpler code.
So seems there's no way that is a pure win over another.
next prev parent reply other threads:[~2013-02-27 10:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-25 6:17 [PATCH v3 1/3] cgroup: fix cgroup_path() vs rename() race Li Zefan
2013-02-25 6:17 ` [PATCH 2/3] cgroup: add cgroup_name() API Li Zefan
2013-02-26 2:27 ` Tejun Heo
2013-02-26 10:25 ` Li Zefan
2013-02-26 13:26 ` Tejun Heo
2013-02-27 10:49 ` Li Zefan [this message]
2013-02-27 13:23 ` Tejun Heo
2013-02-28 6:53 ` Li Zefan
2013-02-28 14:49 ` Tejun Heo
2013-03-01 6:36 ` Li Zefan
2013-03-01 20:39 ` Al Viro
2013-03-01 20:45 ` Tejun Heo
2013-03-04 3:02 ` Li Zefan
2013-03-04 17:38 ` Tejun Heo
2013-02-25 6:18 ` [PATCH 3/3] cpuset: use cgroup_name() in cpuset_print_task_mems_allowed() Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512DE4A8.5050303@huawei.com \
--to=lizefan@huawei.com \
--cc=cgroups@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).