From: "Jan Beulich" <JBeulich@suse.com>
To: "Chen Gang" <gang.chen@asianux.com>
Cc: <roger.pau@citrix.com>, <stefano.stabellini@eu.citrix.com>,
"xen-devel" <xen-devel@lists.xen.org>, <konrad.wilk@oracle.com>,
<dgdegra@tycho.nsa.gov>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers/block/xen-blkback: preq.dev is used without initialized
Date: Wed, 27 Feb 2013 09:57:55 +0000 [thread overview]
Message-ID: <512DE6B302000078000C1631@nat28.tlf.novell.com> (raw)
In-Reply-To: <512D90F2.9070200@asianux.com>
>>> On 27.02.13 at 05:52, Chen Gang <gang.chen@asianux.com> wrote:
> if call xen_vbd_translate failed, the preq.dev will be not initialized.
> so use blkif->vbd.pdevice instead (still better to print relative info).
You also could have mentioned that even before commit
01c681d4c70d64cb72142a2823f27c4146a02e63 the value printed
here was bogus, as it was the guest provided value from
req->u.rw.handle rather than the actual device.
Jan
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> ---
> drivers/block/xen-blkback/blkback.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/block/xen-blkback/blkback.c
> b/drivers/block/xen-blkback/blkback.c
> index de1f319..6d1cc3d 100644
> --- a/drivers/block/xen-blkback/blkback.c
> +++ b/drivers/block/xen-blkback/blkback.c
> @@ -904,7 +904,8 @@ static int dispatch_rw_block_io(struct xen_blkif *blkif,
> pr_debug(DRV_PFX "access denied: %s of [%llu,%llu] on dev=%04x\n",
> operation == READ ? "read" : "write",
> preq.sector_number,
> - preq.sector_number + preq.nr_sects, preq.dev);
> + preq.sector_number + preq.nr_sects,
> + blkif->vbd.pdevice);
> goto fail_response;
> }
>
> --
> 1.7.7.6
next prev parent reply other threads:[~2013-02-27 9:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-27 4:52 [PATCH] drivers/block/xen-blkback: preq.dev is used without initialized Chen Gang
2013-02-27 9:49 ` Jan Beulich
2013-02-27 9:50 ` Roger Pau Monné
2013-02-27 10:03 ` Jan Beulich
2013-02-27 9:57 ` Jan Beulich [this message]
2013-02-27 10:38 ` Chen Gang
2013-02-27 10:45 ` Jan Beulich
2013-02-27 15:40 ` Konrad Rzeszutek Wilk
2013-02-28 1:20 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512DE6B302000078000C1631@nat28.tlf.novell.com \
--to=jbeulich@suse.com \
--cc=dgdegra@tycho.nsa.gov \
--cc=gang.chen@asianux.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roger.pau@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).