From: Ian Lartey <ian@slimlogic.co.uk>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org,
ldewangan@nvidia.com, j-keerthy@ti.com, gg@slimlogic.co.uk,
wim@iguana.be, grant.likely@secretlab.ca,
rob.herring@calxeda.com
Subject: Re: [PATCH 1/2] watchdog: add Palmas Watchdog support
Date: Wed, 27 Feb 2013 22:29:09 +0000 [thread overview]
Message-ID: <512E88B5.6050008@slimlogic.co.uk> (raw)
In-Reply-To: <512E6E5B.7010601@wwwdotorg.org>
On 27/02/13 20:36, Stephen Warren wrote:
> On 02/27/2013 01:17 PM, Ian Lartey wrote:
>> On 27/02/13 18:38, Stephen Warren wrote:
>>> On 02/27/2013 11:36 AM, Ian Lartey wrote:
>>>> From: Graeme Gregory <gg@slimlogic.co.uk>
>>>>
>>>> Add support for the Palmas watchdog timer which has a timeout
>>>> configurable
>>>> from 1s to 128s.
>>>
>>>> diff --git a/drivers/watchdog/palmas_wdt.c
>>>> b/drivers/watchdog/palmas_wdt.c
>>>
>>>> +static struct of_device_id of_palmas_match_tbl[] = {
>>>> + { .compatible = "ti,palmas-wdt", },
>>>> + { /* end */ }
>>>> +};
>>>
>>> Is there a DT binding document for that compatible value?
>>
>> The device tree for this compatible value is actually empty,
>> shall I remove it or is it OK to show it as empty in the
>> bindings document ?
>> There will be other palmas device bindings in this document.
>
> Well, you need a binding document that describes how to create this
> node. If it needs no properties other than compatible, it'll be a simple
> document!
>
> Did you review my comments on the other patches re: whether the
> sub-modules of this HW actually should be sub-nodes in DT or not? If
> not, then you don't need this node in DT, and hence there will be no
> compatible value for the node, and hence no need to write a binding
> document.
I've not reviewed your comments on the other patches, so I'll look at
those before responding properly.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
next prev parent reply other threads:[~2013-02-27 22:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-27 18:36 [PATCH 1/2] watchdog: add Palmas Watchdog support Ian Lartey
2013-02-27 18:36 ` [PATCH 2/2] watchdog: Kconfig for Palmas watchdog driver Ian Lartey
2013-02-27 18:38 ` [PATCH 1/2] watchdog: add Palmas Watchdog support Stephen Warren
2013-02-27 20:17 ` Ian Lartey
2013-02-27 20:36 ` Stephen Warren
2013-02-27 22:29 ` Ian Lartey [this message]
2013-02-28 5:50 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512E88B5.6050008@slimlogic.co.uk \
--to=ian@slimlogic.co.uk \
--cc=gg@slimlogic.co.uk \
--cc=grant.likely@secretlab.ca \
--cc=j-keerthy@ti.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=swarren@wwwdotorg.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).