From: "H. Peter Anvin" <hpa@zytor.com>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
linux-parisc@vger.kernel.org, linux-s390@vger.kernel.org,
Arjan van de Ven <arjan@linux.intel.com>,
Helge Deller <deller@gmx.de>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Chris Metcalf <cmetcalf@tilera.com>
Subject: Re: [PATCH] Consolidate CONFIG_DEBUG_STRICT_USER_COPY_CHECK
Date: Wed, 27 Feb 2013 15:21:06 -0800 [thread overview]
Message-ID: <512E94E2.50809@zytor.com> (raw)
In-Reply-To: <512E9480.7020306@codeaurora.org>
On 02/27/2013 03:19 PM, Stephen Boyd wrote:
> On 02/27/13 14:55, H. Peter Anvin wrote:
>> On 02/27/2013 02:52 PM, Stephen Boyd wrote:
>>> On 02/27/13 14:19, H. Peter Anvin wrote:
>>>> On 02/27/2013 12:42 PM, Stephen Boyd wrote:
>>>>>> It's fine to do your patch as a first step though, which would not
>>>>>> change the behavior.
>>>>> A lot of arches seem to not want to enable it because false positives
>>>>> are everywhere. It really depends on how good the compiler is at doing
>>>>> constant propagation and dead code removal.
>>>>>
>>>> Although some of the cases I have seen being flagged as "false
>>>> positives" have been real bugs.
>>> There were so many false-positives on x86_64 that Andrew eventually
>>> dropped my patch to add support for this option to the copy_from_user()
>>> function there.
>>>
>> I would probably have taken it, especially if it came with more x86-64
>> to i386 unification.
>>
>> It's an option, though.
>
> You acked the patch[1]. Will you pick it up?
>
> [1] https://patchwork.kernel.org/patch/833192/
>
I can, although I would prefer if it came with the uaccess/usercopy
unification.
-hpa
next prev parent reply other threads:[~2013-02-27 23:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-27 3:00 [PATCH] Consolidate CONFIG_DEBUG_STRICT_USER_COPY_CHECKS Stephen Boyd
2013-02-27 20:32 ` [PATCH] Consolidate CONFIG_DEBUG_STRICT_USER_COPY_CHECK Arnd Bergmann
2013-02-27 20:42 ` Stephen Boyd
2013-02-27 21:33 ` Arnd Bergmann
2013-02-27 22:19 ` H. Peter Anvin
2013-02-27 22:45 ` Stephen Rothwell
2013-02-27 22:52 ` H. Peter Anvin
2013-02-27 22:56 ` Arjan van de Ven
2013-02-27 22:52 ` Stephen Boyd
2013-02-27 22:55 ` H. Peter Anvin
2013-02-27 23:19 ` Stephen Boyd
2013-02-27 23:21 ` H. Peter Anvin [this message]
2013-02-27 22:41 ` [PATCH] Consolidate CONFIG_DEBUG_STRICT_USER_COPY_CHECKS Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512E94E2.50809@zytor.com \
--to=hpa@zytor.com \
--cc=akpm@linux-foundation.org \
--cc=arjan@linux.intel.com \
--cc=arnd@arndb.de \
--cc=cmetcalf@tilera.com \
--cc=deller@gmx.de \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sboyd@codeaurora.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).