From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752311Ab3B1Cer (ORCPT ); Wed, 27 Feb 2013 21:34:47 -0500 Received: from intranet.asianux.com ([58.214.24.6]:41639 "EHLO intranet.asianux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750942Ab3B1Cem (ORCPT ); Wed, 27 Feb 2013 21:34:42 -0500 X-Spam-Score: -100.8 Message-ID: <512EC22F.5020404@asianux.com> Date: Thu, 28 Feb 2013 10:34:23 +0800 From: Chen Gang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Konrad Rzeszutek Wilk , Jan Beulich , roger.pau@citrix.com, stefano.stabellini@eu.citrix.com, dgdegra@tycho.nsa.gov CC: xen-devel , "linux-kernel@vger.kernel.org" Subject: [PATCH v2] drivers/block/xen-blkback: preq.dev is used without initialized Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org if call xen_vbd_translate failed, the preq.dev will be not initialized. so use blkif->vbd.pdevice instead (still better to print relative info). additional information: before commit 01c681d4c70d64cb72142a2823f27c4146a02e63, the value printed here was bogus, as it was the guest provided value from req->u.rw.handle rather than the actual device. Signed-off-by: Chen Gang Acked-by: Jan Beulich --- drivers/block/xen-blkback/blkback.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/block/xen-blkback/blkback.c b/drivers/block/xen-blkback/blkback.c index de1f319..6d1cc3d 100644 --- a/drivers/block/xen-blkback/blkback.c +++ b/drivers/block/xen-blkback/blkback.c @@ -904,7 +904,8 @@ static int dispatch_rw_block_io(struct xen_blkif *blkif, pr_debug(DRV_PFX "access denied: %s of [%llu,%llu] on dev=%04x\n", operation == READ ? "read" : "write", preq.sector_number, - preq.sector_number + preq.nr_sects, preq.dev); + preq.sector_number + preq.nr_sects, + blkif->vbd.pdevice); goto fail_response; } -- 1.7.7.6