From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A328C46460 for ; Thu, 9 Aug 2018 21:18:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CF94522393 for ; Thu, 9 Aug 2018 21:18:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CF94522393 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=deltatee.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727327AbeHIXpf (ORCPT ); Thu, 9 Aug 2018 19:45:35 -0400 Received: from ale.deltatee.com ([207.54.116.67]:40922 "EHLO ale.deltatee.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727182AbeHIXpf (ORCPT ); Thu, 9 Aug 2018 19:45:35 -0400 Received: from guinness.priv.deltatee.com ([172.16.1.162]) by ale.deltatee.com with esmtp (Exim 4.89) (envelope-from ) id 1fnsK8-0008EB-0F; Thu, 09 Aug 2018 15:18:24 -0600 To: Bjorn Helgaas Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-doc@vger.kernel.org, Stephen Bates , Christoph Hellwig , Bjorn Helgaas , Jonathan Corbet , Ingo Molnar , Thomas Gleixner , "Paul E. McKenney" , Marc Zyngier , Kai-Heng Feng , Frederic Weisbecker , Dan Williams , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Benjamin Herrenschmidt , Alex Williamson , =?UTF-8?Q?Christian_K=c3=b6nig?= , Matthew Wilcox References: <20180730161840.13733-1-logang@deltatee.com> <20180730161840.13733-2-logang@deltatee.com> <20180809211541.GF113140@bhelgaas-glaptop.roam.corp.google.com> From: Logan Gunthorpe Message-ID: <512aa96e-1c31-ecbd-88c7-a5e417d533ba@deltatee.com> Date: Thu, 9 Aug 2018 15:18:16 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180809211541.GF113140@bhelgaas-glaptop.roam.corp.google.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 172.16.1.162 X-SA-Exim-Rcpt-To: willy@infradead.org, christian.koenig@amd.com, alex.williamson@redhat.com, benh@kernel.crashing.org, jglisse@redhat.com, dan.j.williams@intel.com, frederic@kernel.org, kai.heng.feng@canonical.com, marc.zyngier@arm.com, paulmck@linux.vnet.ibm.com, tglx@linutronix.de, mingo@kernel.org, corbet@lwn.net, bhelgaas@google.com, hch@lst.de, sbates@raithlin.com, linux-doc@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, helgaas@kernel.org X-SA-Exim-Mail-From: logang@deltatee.com Subject: Re: [PATCH v8 1/4] PCI: Make specifying PCI devices in kernel parameters reusable X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/08/18 03:15 PM, Bjorn Helgaas wrote: >> @@ -2994,7 +2994,26 @@ >> See header of drivers/block/paride/pcd.c. >> See also Documentation/blockdev/paride.txt. >> >> - pci=option[,option...] [PCI] various PCI subsystem options: >> + pci=option[,option...] [PCI] various PCI subsystem options. >> + >> + Some options herein operate on a specific device >> + or a set of devices (). These are >> + specified in one of the following formats: >> + >> + [:]:. >> + pci::[::] >> + >> + Note: the first format specifies a PCI >> + bus/slot/function address which may change > > Unless you object, I'm going to change "slot" references like this to > "device" so they match "BDF" and the language in the spec, which uses > "slot" to refer to a physical slot and "device" when referring to > geographical device addresses. I can do this when I apply these, so > no need for you to repost them. No objection. I never liked the "slot" reference but was trying to remain consistent with what was there before. If I remember correctly there's a bunch of places in the kernel that use slot as well. Thanks, Logan