From: Shuah Khan <shuahkh@osg.samsung.com>
To: Darren Hart <dvhart@infradead.org>
Cc: shuah@kernel.org, bamvor.zhangjian@linaro.org,
benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au,
viro@zeniv.linux.org.uk, emilio.lopez@collabora.co.uk,
mingo@kernel.org, luto@kernel.org, dave.hansen@linux.intel.com,
dsafonov@virtuozzo.com, rkrcmar@redhat.com,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
shuah Khan <shuahkh@osg.samsung.com>
Subject: Re: [PATCH 3/8] selftests: futex: override clean in lib.mk to fix warnings
Date: Thu, 27 Apr 2017 15:57:13 -0600 [thread overview]
Message-ID: <512c6179-00bd-180f-dff5-7b81d181ae81@osg.samsung.com> (raw)
In-Reply-To: <20170427215437.GC29261@fury>
On 04/27/2017 03:54 PM, Darren Hart wrote:
> On Fri, Apr 21, 2017 at 05:14:45PM -0600, Shuah Khan wrote:
>> Add override for lib.mk clean to fix the following warnings from clean
>> target run.
>>
>> Makefile:36: warning: overriding recipe for target 'clean'
>> ../lib.mk:55: warning: ignoring old recipe for target 'clean'
>>
>> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
>> ---
>> tools/testing/selftests/futex/Makefile | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/tools/testing/selftests/futex/Makefile b/tools/testing/selftests/futex/Makefile
>> index c8095e6..e2fbb89 100644
>> --- a/tools/testing/selftests/futex/Makefile
>> +++ b/tools/testing/selftests/futex/Makefile
>> @@ -32,9 +32,10 @@ override define EMIT_TESTS
>> echo "./run.sh"
>> endef
>>
>> -clean:
>> +override define CLEAN
>> for DIR in $(SUBDIRS); do \
>> BUILD_TARGET=$(OUTPUT)/$$DIR; \
>> mkdir $$BUILD_TARGET -p; \
>> make OUTPUT=$$BUILD_TARGET -C $$DIR $@;\
>> done
>> +endef
>
> Taking the move of clean into lib.mk as a given,
Yeah I considered undoing that, and chose to fix the missed
issues instead.
>
> Acked-by: Darren Hart (VMware) <dvhart@infradead.org>
>
thanks,
-- Shuah
next prev parent reply other threads:[~2017-04-27 21:57 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 23:14 [PATCH 0/8] Fix clean target warnings Shuah Khan
2017-04-21 23:14 ` [PATCH 1/8] selftests: splice: fix clean target to not remove default_file_splice_read.sh Shuah Khan
2017-04-21 23:14 ` [PATCH 2/8] selftests: lib.mk: define CLEAN macro to allow Makefiles to override clean Shuah Khan
2017-04-22 5:38 ` Michael Ellerman
2017-04-25 13:36 ` Shuah Khan
2017-04-26 10:55 ` Michael Ellerman
2017-04-24 15:45 ` David Laight
2017-04-24 19:46 ` Shuah Khan
2017-04-21 23:14 ` [PATCH 3/8] selftests: futex: override clean in lib.mk to fix warnings Shuah Khan
2017-04-27 21:54 ` Darren Hart
2017-04-27 21:57 ` Shuah Khan [this message]
2017-04-21 23:14 ` [PATCH 4/8] selftests: gpio: " Shuah Khan
2017-04-22 5:40 ` Michael Ellerman
2017-04-25 15:02 ` Shuah Khan
2017-04-21 23:14 ` [PATCH 5/8] selftests: powerpc: " Shuah Khan
2017-04-21 23:14 ` [PATCH 6/8] selftests: splice: " Shuah Khan
2017-04-22 5:40 ` Michael Ellerman
2017-04-25 15:03 ` Shuah Khan
2017-04-21 23:14 ` [PATCH 7/8] selftests: sync: " Shuah Khan
2017-04-22 5:41 ` Michael Ellerman
2017-04-25 15:03 ` Shuah Khan
2017-04-21 23:14 ` [PATCH 8/8] selftests: x86: " Shuah Khan
2017-04-22 5:41 ` Michael Ellerman
2017-04-24 15:57 ` David Laight
2017-04-24 19:48 ` Shuah Khan
2017-04-25 15:03 ` Shuah Khan
2017-04-27 22:02 ` [PATCH 0/8] Fix clean target warnings Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512c6179-00bd-180f-dff5-7b81d181ae81@osg.samsung.com \
--to=shuahkh@osg.samsung.com \
--cc=bamvor.zhangjian@linaro.org \
--cc=benh@kernel.crashing.org \
--cc=dave.hansen@linux.intel.com \
--cc=dsafonov@virtuozzo.com \
--cc=dvhart@infradead.org \
--cc=emilio.lopez@collabora.co.uk \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=rkrcmar@redhat.com \
--cc=shuah@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).