From: Joe Perches <joe@perches.com>
To: Jonathan Corbet <corbet@lwn.net>
Cc: Stephen Kitt <steve@sk2.org>, Kees Cook <keescook@chromium.org>,
Nitin Gote <nitin.r.gote@intel.com>,
jannh@google.com, kernel-hardening@lists.openwall.com,
linux-kernel@vger.kernel.org,
Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Subject: Re: [PATCH] checkpatch: Added warnings in favor of strscpy().
Date: Mon, 22 Jul 2019 15:24:33 -0700 [thread overview]
Message-ID: <512d8977fb0d0b3eef7b6ea1753fb4c33fbc43e8.camel@perches.com> (raw)
In-Reply-To: <20190722155730.08dfd4e3@lwn.net>
On Mon, 2019-07-22 at 15:57 -0600, Jonathan Corbet wrote:
> On Mon, 22 Jul 2019 14:50:09 -0700
> Joe Perches <joe@perches.com> wrote:
>
> > On Mon, 2019-07-22 at 23:01 +0200, Stephen Kitt wrote:
> > > How about you submit your current patch set, and I follow up with the above
> > > adapted to stracpy?
> >
> > OK, I will shortly after I figure out how to add kernel-doc
> > for stracpy/stracpy_pad to lib/string.c.
> >
> > It doesn't seem appropriate to add the kernel-doc to string.h
> > as it would be separated from the others in string.c
> >
> > Anyone got a clue here? Jonathan?
>
> If the functions themselves are fully defined in the .h file, I'd just add
> the kerneldoc there as well. That's how it's usually done, and you want
> to keep the documentation and the prototypes together.
In this case, it's a macro and yes, the kernel-doc could
easily be set around the macro in the .h, but my desire
is to keep all the string function kernel-doc output
together so it should be added to lib/string.c
Are you suggesting I move all the lib/string.c kernel-doc
to include/linux/string.h ?
next prev parent reply other threads:[~2019-07-22 22:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1561722948-28289-1-git-send-email-nitin.r.gote@intel.com>
[not found] ` <20190629181537.7d524f7d@sk2.org>
[not found] ` <201907021024.D1C8E7B2D@keescook>
[not found] ` <20190706144204.15652de7@heffalump.sk2.org>
2019-07-22 17:50 ` [PATCH] checkpatch: Added warnings in favor of strscpy() Kees Cook
2019-07-22 17:59 ` Joe Perches
2019-07-22 21:01 ` Stephen Kitt
2019-07-22 21:50 ` Joe Perches
2019-07-22 21:57 ` Jonathan Corbet
2019-07-22 22:24 ` Joe Perches [this message]
2019-07-22 22:28 ` Jonathan Corbet
2019-07-22 22:35 ` Joe Perches
2019-07-24 11:41 ` Joe Perches
2019-07-04 5:54 Nitin Gote
2019-07-04 20:46 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512d8977fb0d0b3eef7b6ea1753fb4c33fbc43e8.camel@perches.com \
--to=joe@perches.com \
--cc=corbet@lwn.net \
--cc=jannh@google.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nitin.r.gote@intel.com \
--cc=rasmus.villemoes@prevas.dk \
--cc=steve@sk2.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).