From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Aaron Lu <aaron.lu@intel.com>
Cc: Jeff Garzik <jgarzik@pobox.com>, Tejun Heo <tj@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
Jeff Garzik <jgarzik@redhat.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
LKML <linux-kernel@vger.kernel.org>,
Linux PM list <linux-pm@vger.kernel.org>
Subject: Re: [PATCH] [libata] Avoid specialized TLA's in ZPODD's Kconfig
Date: Fri, 01 Mar 2013 17:10:55 +0400 [thread overview]
Message-ID: <5130A8DF.7080709@cogentembedded.com> (raw)
In-Reply-To: <5130052E.9070403@intel.com>
Hello.
On 01-03-2013 5:32, Aaron Lu wrote:
> ODD is not a common TLA for non-ATA people so they will get confused
> by its meaning when they are configuring the kernel. This patch fixed
> this problem by using ODD only after stating what it is.
> Signed-off-by: Aaron Lu <aaron.lu@intel.com>
> ---
> drivers/ata/Kconfig | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index 3e751b7..d7d210e 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -59,15 +59,16 @@ config ATA_ACPI
> option libata.noacpi=1
>
> config SATA_ZPODD
> - bool "SATA Zero Power ODD Support"
> + bool "SATA Zero Power Optical Disc Drive(ZPODD) support"
Need a space before open paren.
> depends on ATA_ACPI
> default n
> help
> - This option adds support for SATA ZPODD. It requires both
> - ODD and the platform support, and if enabled, will automatically
> - power on/off the ODD when certain condition is satisfied. This
> - does not impact user's experience of the ODD, only power is saved
> - when ODD is not in use(i.e. no disc inside).
> + This option adds support for SATA Zero Power Optical Disc
> + Drive(ZPODD). It requires both the ODD and the platform
Same here.
> + support, and if enabled, will automatically power on/off the
> + ODD when certain condition is satisfied. This does not impact
> + end user's experience of the ODD, only power is saved when
> + the ODD is not in use(i.e. no disc inside).
And here.
MBR, Sergei
next prev parent reply other threads:[~2013-03-01 13:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-24 14:29 [GIT PULL] ACPI and power management fixes for v3.9-rc1 Rafael J. Wysocki
2013-02-26 3:17 ` Rafael J. Wysocki
2013-02-26 5:31 ` Linus Torvalds
2013-02-26 15:55 ` Rafael J. Wysocki
2013-02-26 16:10 ` Nishanth Menon
2013-02-26 16:27 ` Linus Torvalds
2013-02-26 16:28 ` Linus Torvalds
2013-02-26 16:37 ` Tejun Heo
2013-02-26 16:47 ` Linus Torvalds
2013-02-26 16:58 ` Tejun Heo
2013-02-26 17:59 ` Jeff Garzik
2013-03-01 1:32 ` [PATCH] [libata] Avoid specialized TLA's in ZPODD's Kconfig Aaron Lu
2013-03-01 13:10 ` Sergei Shtylyov [this message]
2013-03-02 5:00 ` [PATCH v2] " Aaron Lu
2013-03-04 22:14 ` Jeff Garzik
2013-02-27 2:24 ` [GIT PULL] ACPI and power management fixes for v3.9-rc1 Aaron Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5130A8DF.7080709@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=aaron.lu@intel.com \
--cc=jgarzik@pobox.com \
--cc=jgarzik@redhat.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).