From: Joe Perches <joe@perches.com>
To: mgross@linux.intel.com, markgross@kernel.org, arnd@arndb.de,
bp@suse.de, damien.lemoal@wdc.com, dragan.cvetic@xilinx.com,
gregkh@linuxfoundation.org, corbet@lwn.net,
palmerdabbelt@google.com, paul.walmsley@sifive.com,
peng.fan@nxp.com, robh+dt@kernel.org, shawnguo@kernel.org,
jassisinghbrar@gmail.com
Cc: linux-kernel@vger.kernel.org, "C,
Udhayakumar" <udhayakumar.c@intel.com>,
C@linux.intel.com
Subject: Re: [PATCH v3 28/34] misc: Intel tsens IA host driver.
Date: Fri, 29 Jan 2021 23:01:30 -0800 [thread overview]
Message-ID: <5137ab3793f03c17a719445f14131c16e7766434.camel@perches.com> (raw)
In-Reply-To: <20210130022124.65083-29-mgross@linux.intel.com>
On Fri, 2021-01-29 at 18:20 -0800, mgross@linux.intel.com wrote:
> From: "C, Udhayakumar" <udhayakumar.c@intel.com>
>
> Add Intel tsens IA host driver for Intel Edge.AI Computer Vision
> platforms.
[]
> diff --git a/drivers/misc/intel_tsens/intel_tsens_host.c b/drivers/misc/intel_tsens/intel_tsens_host.c
[]
> +static int tsens_i2c_smbus_read_byte_data(struct i2c_client *i2c, u8 command,
> + u8 *i2c_val)
> +{
> + union i2c_smbus_data data;
> + int status;
> +
> + status = i2c_smbus_xfer(i2c->adapter, i2c->addr, i2c->flags,
> + I2C_SMBUS_READ, command,
> + I2C_SMBUS_BYTE_DATA, &data);
this can fail
> + *i2c_val = data.byte;
Is it appropriate to set the value if it failed and data was
not initialized?
> + return status;
> +}
> +
> +/**
> + * intel_tsens_get_temp - get updated temperatue
Might want to use codespell on all files.
next prev parent reply other threads:[~2021-01-30 9:28 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-30 2:20 [PATCH v3 00/34] Intel Vision Processing base enabling mgross
2021-01-30 2:20 ` [PATCH v3 01/34] Add Vision Processing Unit (VPU) documentation mgross
2021-01-30 2:20 ` [PATCH v3 02/34] dt-bindings: mailbox: Add Intel VPU IPC mailbox bindings mgross
2021-01-30 2:20 ` [PATCH v3 03/34] mailbox: vpu-ipc-mailbox: Add support for Intel VPU IPC mailbox mgross
2021-02-01 7:07 ` Jassi Brar
2021-02-01 15:49 ` Alessandrelli, Daniele
2021-01-30 2:20 ` [PATCH v3 04/34] dt-bindings: Add bindings for Keem Bay IPC driver mgross
2021-01-30 2:20 ` [PATCH v3 05/34] keembay-ipc: Add Keem Bay IPC module mgross
2021-01-30 2:20 ` [PATCH v3 06/34] dt-bindings: Add bindings for Keem Bay VPU IPC driver mgross
2021-01-30 2:20 ` [PATCH v3 07/34] keembay-vpu-ipc: Add Keem Bay VPU IPC module mgross
2021-01-30 2:20 ` [PATCH v3 08/34] misc: xlink-pcie: Add documentation for XLink PCIe driver mgross
2021-01-30 2:20 ` [PATCH v3 09/34] misc: xlink-pcie: lh: Add PCIe EPF driver for Local Host mgross
2021-01-30 2:20 ` [PATCH v3 10/34] misc: xlink-pcie: lh: Add PCIe EP DMA functionality mgross
2021-01-30 2:20 ` [PATCH v3 11/34] misc: xlink-pcie: lh: Add core communication logic mgross
2021-01-30 2:20 ` [PATCH v3 12/34] misc: xlink-pcie: lh: Prepare changes for adding remote host driver mgross
2021-01-30 2:20 ` [PATCH v3 13/34] misc: xlink-pcie: rh: Add PCIe EP driver for Remote Host mgross
2021-01-30 2:20 ` [PATCH v3 14/34] misc: xlink-pcie: rh: Add core communication logic mgross
2021-01-30 2:20 ` [PATCH v3 15/34] misc: xlink-pcie: Add XLink API interface mgross
2021-01-30 2:20 ` [PATCH v3 16/34] misc: xlink-pcie: Add asynchronous event notification support for XLink mgross
2021-01-30 2:20 ` [PATCH v3 17/34] xlink-ipc: Add xlink ipc device tree bindings mgross
2021-01-30 2:20 ` [PATCH v3 18/34] xlink-ipc: Add xlink ipc driver mgross
2021-01-30 2:20 ` [PATCH v3 19/34] xlink-core: Add xlink core device tree bindings mgross
2021-01-30 2:20 ` [PATCH v3 20/34] xlink-core: Add xlink core driver xLink mgross
2021-01-30 2:20 ` [PATCH v3 21/34] xlink-core: Enable xlink protocol over pcie mgross
2021-01-30 2:20 ` [PATCH v3 22/34] xlink-core: Enable VPU IP management and runtime control mgross
2021-01-30 2:20 ` [PATCH v3 23/34] xlink-core: add async channel and events mgross
2021-01-30 2:20 ` [PATCH v3 24/34] dt-bindings: misc: Add Keem Bay vpumgr mgross
2021-01-30 2:20 ` [PATCH v3 25/34] misc: Add Keem Bay VPU manager mgross
2021-02-01 2:04 ` Randy Dunlap
2021-01-30 2:20 ` [PATCH v3 26/34] dt-bindings: misc: intel_tsens: Add tsens thermal bindings documentation mgross
2021-01-30 2:20 ` [PATCH v3 27/34] misc: Tsens ARM host thermal driver mgross
2021-01-30 2:20 ` [PATCH v3 28/34] misc: Intel tsens IA host driver mgross
2021-01-30 7:01 ` Joe Perches [this message]
2021-02-02 7:21 ` C, Udhayakumar
2021-01-30 2:20 ` [PATCH v3 29/34] Intel tsens i2c slave driver mgross
2021-02-01 2:07 ` Randy Dunlap
2021-01-30 2:20 ` [PATCH v3 30/34] misc:intel_tsens: Intel Keem Bay tsens driver mgross
2021-01-30 2:20 ` [PATCH v3 31/34] Intel Keem Bay XLink SMBus driver mgross
2021-01-30 2:20 ` [PATCH v3 32/34] dt-bindings: misc: hddl_dev: Add hddl device management documentation mgross
2021-01-30 2:20 ` [PATCH v3 33/34] misc: Hddl device management for local host mgross
2021-01-30 2:20 ` [PATCH v3 34/34] misc: HDDL device management for IA host mgross
2021-01-30 2:20 ` [PATCH v4 00/34] Intel Vision Processing base enabling mgross
2021-01-30 2:20 ` [PATCH v4 01/34] Add Vision Processing Unit (VPU) documentation mgross
2021-01-30 2:20 ` [PATCH v4 02/34] dt-bindings: mailbox: Add Intel VPU IPC mailbox bindings mgross
2021-01-30 2:20 ` [PATCH v4 03/34] mailbox: vpu-ipc-mailbox: Add support for Intel VPU IPC mailbox mgross
2021-01-30 2:20 ` [PATCH v4 04/34] dt-bindings: Add bindings for Keem Bay IPC driver mgross
2021-01-30 2:20 ` [PATCH v4 05/34] keembay-ipc: Add Keem Bay IPC module mgross
2021-01-30 2:20 ` [PATCH v4 06/34] dt-bindings: Add bindings for Keem Bay VPU IPC driver mgross
2021-01-30 2:20 ` [PATCH v4 07/34] keembay-vpu-ipc: Add Keem Bay VPU IPC module mgross
2021-01-30 2:20 ` [PATCH v4 08/34] misc: xlink-pcie: Add documentation for XLink PCIe driver mgross
2021-01-30 2:20 ` [PATCH v4 09/34] misc: xlink-pcie: lh: Add PCIe EPF driver for Local Host mgross
2021-01-30 2:21 ` [PATCH v4 10/34] misc: xlink-pcie: lh: Add PCIe EP DMA functionality mgross
2021-01-30 2:21 ` [PATCH v4 11/34] misc: xlink-pcie: lh: Add core communication logic mgross
2021-01-30 2:21 ` [PATCH v4 12/34] misc: xlink-pcie: lh: Prepare changes for adding remote host driver mgross
2021-01-30 2:21 ` [PATCH v4 13/34] misc: xlink-pcie: rh: Add PCIe EP driver for Remote Host mgross
2021-01-30 2:21 ` [PATCH v4 14/34] misc: xlink-pcie: rh: Add core communication logic mgross
2021-01-30 2:21 ` [PATCH v4 15/34] misc: xlink-pcie: Add XLink API interface mgross
2021-01-30 2:21 ` [PATCH v4 16/34] misc: xlink-pcie: Add asynchronous event notification support for XLink mgross
2021-01-30 2:21 ` [PATCH v4 17/34] xlink-ipc: Add xlink ipc device tree bindings mgross
2021-01-30 2:21 ` [PATCH v4 18/34] xlink-ipc: Add xlink ipc driver mgross
2021-01-30 2:21 ` [PATCH v4 19/34] xlink-core: Add xlink core device tree bindings mgross
2021-01-30 2:21 ` [PATCH v4 20/34] xlink-core: Add xlink core driver xLink mgross
2021-01-30 2:21 ` [PATCH v4 21/34] xlink-core: Enable xlink protocol over pcie mgross
2021-01-30 2:21 ` [PATCH v4 22/34] xlink-core: Enable VPU IP management and runtime control mgross
2021-01-30 2:21 ` [PATCH v4 23/34] xlink-core: add async channel and events mgross
2021-01-30 2:21 ` [PATCH v4 24/34] dt-bindings: misc: Add Keem Bay vpumgr mgross
2021-01-30 2:21 ` [PATCH v4 25/34] misc: Add Keem Bay VPU manager mgross
2021-01-30 2:21 ` [PATCH v4 26/34] dt-bindings: misc: intel_tsens: Add tsens thermal bindings documentation mgross
2021-01-30 17:23 ` Rob Herring
2021-02-02 8:47 ` C, Udhayakumar
2021-01-30 2:21 ` [PATCH v4 27/34] misc: Tsens ARM host thermal driver mgross
2021-01-30 2:21 ` [PATCH v4 28/34] misc: Intel tsens IA host driver mgross
2021-01-30 2:21 ` [PATCH v4 29/34] Intel tsens i2c slave driver mgross
2021-02-01 2:13 ` Randy Dunlap
2021-02-01 15:20 ` Gross, Mark
2021-01-30 2:21 ` [PATCH v4 30/34] misc:intel_tsens: Intel Keem Bay tsens driver mgross
2021-01-30 2:21 ` [PATCH v4 31/34] Intel Keem Bay XLink SMBus driver mgross
2021-01-30 2:21 ` [PATCH v4 32/34] dt-bindings: misc: hddl_dev: Add hddl device management documentation mgross
2021-01-30 17:23 ` Rob Herring
2021-02-02 8:48 ` C, Udhayakumar
2021-01-30 2:21 ` [PATCH v4 33/34] misc: Hddl device management for local host mgross
2021-01-30 2:21 ` [PATCH v4 34/34] misc: HDDL device management for IA host mgross
-- strict thread matches above, loose matches on Subject: below --
2021-01-26 5:40 [PATCH v3 00/34] Intel Vision Processing base enabling mgross
2021-01-26 5:40 ` [PATCH v3 28/34] misc: Intel tsens IA host driver mgross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5137ab3793f03c17a719445f14131c16e7766434.camel@perches.com \
--to=joe@perches.com \
--cc=C@linux.intel.com \
--cc=arnd@arndb.de \
--cc=bp@suse.de \
--cc=corbet@lwn.net \
--cc=damien.lemoal@wdc.com \
--cc=dragan.cvetic@xilinx.com \
--cc=gregkh@linuxfoundation.org \
--cc=jassisinghbrar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=mgross@linux.intel.com \
--cc=palmerdabbelt@google.com \
--cc=paul.walmsley@sifive.com \
--cc=peng.fan@nxp.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=udhayakumar.c@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).