From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756949AbcH2JB2 (ORCPT ); Mon, 29 Aug 2016 05:01:28 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:58438 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756632AbcH2JBY (ORCPT ); Mon, 29 Aug 2016 05:01:24 -0400 From: Arnd Bergmann To: ksummit-discuss@lists.linuxfoundation.org Cc: Alexandre Belloni , "Levin, Alexander" , Joe Perches , Greg KH , Sasha Levin , LKML Subject: Re: [Ksummit-discuss] checkkpatch (in)sanity ? Date: Mon, 29 Aug 2016 11:01:08 +0200 Message-ID: <5149968.BflLUdM3a8@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <20160829071515.wqlpjccq7a3vk7u6@piout.net> References: <1472330452.26978.23.camel@perches.com> <20160828223759.GA12993@sasha-lappy> <20160829071515.wqlpjccq7a3vk7u6@piout.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:k3WevI1MLfwhPZz4+Z7bVL6mGNHX1wtv5wdAWt33QSKzCtHawu4 QS7LaSzAfqIb/V91e3t3eBEBIlzTkuBBwMIHzYkCTnflqY4Iu/Jzz4D4YXAyGJjnNW/IPgE zYxASIEufP+//aaeeeinecslQw2PBkmQjvKMATW4MafbsATFC2FgFW9Vvt9y/xnPdU9ecYC JgM+HXuWSeqBb5fvSs1Fw== X-UI-Out-Filterresults: notjunk:1;V01:K0:iVmXZ7G9v18=:mkKa5KzgoegkRk0C01BUtw 3cWtbF2oqaoVHckiBRfEkCKf3l7l5/vj3q/qDa2OjPoCnz2VJvRoauCaecwLKCw56qsXsN/7g P/ZPtalAmBCOH0m4XGNI9Gw/SpzzjSh2Bj17eoUcfxfdx3LvvgM3FTWSfR0xeWa/yQYTD4LZe VKOtWvMOwea5bAzSa66kwvyIeNFsQaHmIC9ByybMZyThjWjzswvdWeUj60gHQ1xORaU5I5Ax7 OK6n6EX1ox0D/2Ilp/FRjMbOQfGEt7N0blHdzh7iXWFUmjtTP1BqZ5upOvu0U0lSm4rAEy7wS JTadiTWEeYDupgC9stJd2N5vaUAaJo9KVvuq8YI7zMwx2BAnf4rdOiRNuuka7NNOn8L8bczp/ zNP9m+CudQgTXoc0zVsunAuPQBf/IY7he06VoqXH3co5CsY3gqilsDH6aOKoEk0EGOeiehq1k FXHAjXMjoS8WQAv3xEcNpEP3dRdHjnfkngAPk6kIw2YxGMb4FRVfkv3DrNqNGcsOoexPy7Maw XKe/fMPyfNm1nQtX8nfwe8JmNT0fEyvGbET1HxoUU3cPGchq17bJyWwEY/b7TAkVb7z6Iozqk dA5ULVsDItoOlTVn269CkUAb7kKwfEwEIDP7nk2+XQgTqmxn5TeA4NRELKN3khgAKYolylzag 7Q6mumG3ZgfV0aiq5Wqd9murK+LsiOncmOxRgIPirL1wT8CtbfCAO9juRC0ge+7ZTuGxXRHwN D4cvCO6kgbcZBPpp Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, August 29, 2016 9:15:15 AM CEST Alexandre Belloni wrote: > > > > commiter commits issues > > arnd 858 2155 > > axboe 53 22 > > corbet 15 9 > > davem 55 81 > > grant.likely 2 0 > > gregkh 38 46 > > hch 393 581 > > James.Bottomley 15 15 > > martin.petersen 18 20 > > mchehab 678 1042 > > mgorman 104 256 > > mingo 58 192 > > paulmck 176 68 > > peterz 226 511 > > rostedt 123 178 > > shuahkh 53 6 > > tglx 200 287 > > torvalds 64 89 > > tytso 37 77 > > viro 350 256 > > > > And for the last 10,000 commits in the log, that script has observed 10,783 issues. > > > > It'll be interesting to hear from these people about their view of checkpatch, but IMO when on average there are more issues than commits I can suggest two possible causes: > > > > 1. People are used to ignore checkpatch warnings. > > 2. People aren't using checkpatch. > > > > Well, Arnd is used to move around old code when refactoring. As the code > just moves, he rarely solves checkpatch issues when doing so which is > the right thing to do. I don't find checkpatch.pl overly useful for my own patches and rarely run it. I looked over the last few hundred commits and found that almost all the warnings were for: - having overly long lines in commit messages when I quoted a long compiler warning. I generally don't wrap those to make it easier to search for the warnings in the git history - missing the word "commit" before a reference to another changeset in full-text. I'll change that in the future if that makes people happy, but it doesn't seem important. - existing style issues that I did not fix when fixing a bug. In many cases I find it better not to change coding style while fixing a bug, but there are other cases in which I do. Arnd