From: Jon Hunter <jonathanh@nvidia.com>
To: Dmitry Osipenko <digetx@gmail.com>,
Ion Agorria <AG0RRIA@yahoo.com>,
Thierry Reding <thierry.reding@gmail.com>,
Stephen Warren <swarren@nvidia.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.com>,
Jaroslav Kysela <perex@perex.cz>,
Rob Herring <robh+dt@kernel.org>,
Svyatoslav Ryhel <clamor95@gmail.com>,
Ion Agorria <ion@agorria.com>
Cc: <alsa-devel@alsa-project.org>, <devicetree@vger.kernel.org>,
<linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 2/2] ASoC: tegra: Add RT5631 machine driver
Date: Tue, 2 Feb 2021 16:24:31 +0000 [thread overview]
Message-ID: <51571ec9-780b-ba71-c81d-dd01ebcefbb8@nvidia.com> (raw)
In-Reply-To: <8d0bc6f3-45ce-565d-d80f-b50fb75e7c55@gmail.com>
On 02/02/2021 15:25, Dmitry Osipenko wrote:
> 02.02.2021 16:22, Jon Hunter пишет:
>> So this is very similar to tegra_rt5677, is it not possible to support
>> both codecs with the same machine driver?
>
> These codecs require individual configurations and those
> "../codecs/rt5631.h" and "../codecs/rt5677.h" aren't compatible at a
> quick glance.
Right but not all of that is needed. What is actually needed from the
header files?
> The tegra_rt5677 also uses outdated GPIO API and etc. Hence the new
> driver should be a better base anyways.
Sounds like a good time to update it :-)
> Overall it shouldn't worth time and effort trying to squeeze these
> drivers into a single one, IMO.
Not sure I agree when these drivers appear to be 90% the same.
Jon
--
nvpublic
next prev parent reply other threads:[~2021-02-02 17:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210131184101.651486-1-AG0RRIA.ref@yahoo.com>
[not found] ` <20210131184101.651486-1-AG0RRIA@yahoo.com>
[not found] ` <20210131184101.651486-2-AG0RRIA@yahoo.com>
2021-02-02 13:16 ` [PATCH v1 1/2] ASoC: dt-bindings: tegra: Add binding for RT5631 Jon Hunter
[not found] ` <20210131184101.651486-3-AG0RRIA@yahoo.com>
2021-02-02 13:22 ` [PATCH v1 2/2] ASoC: tegra: Add RT5631 machine driver Jon Hunter
2021-02-02 15:25 ` Dmitry Osipenko
2021-02-02 16:24 ` Jon Hunter [this message]
2021-02-02 16:57 ` Dmitry Osipenko
2021-02-02 17:00 ` Mark Brown
2021-02-02 15:54 ` Dmitry Osipenko
2021-02-02 13:23 ` [PATCH v1 0/2] " Jon Hunter
2021-02-03 21:42 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51571ec9-780b-ba71-c81d-dd01ebcefbb8@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=AG0RRIA@yahoo.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=clamor95@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=ion@agorria.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=swarren@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).