From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756284Ab3DCIBD (ORCPT ); Wed, 3 Apr 2013 04:01:03 -0400 Received: from intranet.asianux.com ([58.214.24.6]:51572 "EHLO intranet.asianux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751833Ab3DCIBB (ORCPT ); Wed, 3 Apr 2013 04:01:01 -0400 X-Spam-Score: -100.7 Message-ID: <515BE19F.2080709@asianux.com> Date: Wed, 03 Apr 2013 16:00:31 +0800 From: Chen Gang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: drbd-dev@lists.linbit.com CC: drbd-user@lists.linbit.com, "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] drivers/block/drbd: remove erroneous semicolon References: <5152980D.8090903@asianux.com> In-Reply-To: <5152980D.8090903@asianux.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello maintainers: when you have time, please help to check this patch whether is OK. thanks. gchen. On 2013年03月27日 14:56, Chen Gang wrote: > > need remove it, or always return -EBUSY. > it is found by compiler with 'EXTRA_CFLAG=-W'. > > Signed-off-by: Chen Gang > --- > drivers/block/drbd/drbd_actlog.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/block/drbd/drbd_actlog.c b/drivers/block/drbd/drbd_actlog.c > index 6afe173..6608076 100644 > --- a/drivers/block/drbd/drbd_actlog.c > +++ b/drivers/block/drbd/drbd_actlog.c > @@ -389,7 +389,7 @@ int drbd_al_begin_io_nonblock(struct drbd_conf *mdev, struct drbd_interval *i) > if (unlikely(tmp != NULL)) { > struct bm_extent *bm_ext = lc_entry(tmp, struct bm_extent, lce); > if (test_bit(BME_NO_WRITES, &bm_ext->flags)) { > - if (!test_and_set_bit(BME_PRIORITY, &bm_ext->flags)); > + if (!test_and_set_bit(BME_PRIORITY, &bm_ext->flags)) > return -EBUSY; > return -EWOULDBLOCK; > } > -- Chen Gang Asianux Corporation